-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Job Step Properties limits and basic validation #3318
Merged
Coduz
merged 6 commits into
eclipse:develop
from
Coduz:feature-jobStepDefinitionPropertyLimits
Jun 1, 2021
Merged
Job Step Properties limits and basic validation #3318
Coduz
merged 6 commits into
eclipse:develop
from
Coduz:feature-jobStepDefinitionPropertyLimits
Jun 1, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coduz
force-pushed
the
feature-jobStepDefinitionPropertyLimits
branch
from
May 28, 2021 10:38
21fbdbb
to
9524e99
Compare
Codecov Report
@@ Coverage Diff @@
## develop #3318 +/- ##
==============================================
- Coverage 55.02% 25.81% -29.21%
+ Complexity 794 661 -133
==============================================
Files 1488 1488
Lines 30009 30080 +71
Branches 2498 2507 +9
==============================================
- Hits 16511 7764 -8747
- Misses 12581 21714 +9133
+ Partials 917 602 -315
|
Coduz
force-pushed
the
feature-jobStepDefinitionPropertyLimits
branch
from
May 28, 2021 11:12
9524e99
to
0f2f617
Compare
Signed-off-by: Alberto Codutti <alberto.codutti@eurotech.com>
Coduz
force-pushed
the
feature-jobStepDefinitionPropertyLimits
branch
from
May 28, 2021 12:34
0f2f617
to
ffa6a2a
Compare
Signed-off-by: Alberto Codutti <alberto.codutti@eurotech.com>
lorthirk
approved these changes
May 29, 2021
Signed-off-by: Alberto Codutti <alberto.codutti@eurotech.com>
Signed-off-by: Alberto Codutti <alberto.codutti@eurotech.com>
Signed-off-by: Alberto Codutti <alberto.codutti@eurotech.com>
Signed-off-by: Alberto Codutti <alberto.codutti@eurotech.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add some fields to perform validation on
JobStepProperty
es when creating a Step.As per default no validation is added for existing
JobStepDefinitions
to not break any existing JobStep Definition.Related Issue
None
Description of the solution adopted
Added following fields to
JobStepProperty
:These fields will be enforced only if specified.
Screenshots
None
Any side note on the changes made
None