Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Job Step Properties required attribute #3339

Merged

Conversation

Coduz
Copy link
Contributor

@Coduz Coduz commented Jun 24, 2021

This PR adds required field to the JobStepProperty.
Now the mandatory-ness was determined by the JobStepProperty having a propertyValue or not, which prevents leaving parameters not defined.

Related Issue
This PR is an integration of #3318

Description of the solution adopted
Added a new field.

Old existing JobStepDefinitions.property gets the value of required based on the value of propertyValue which leaves the behaviour unchanged.

Screenshots
None

Any side note on the changes made
FIxed parsing of KapuaId and byte[] JobStepProperties types

Signed-off-by: Alberto Codutti <alberto.codutti@eurotech.com>
@Coduz Coduz added the Enhancement This PR/Issue improves an part of Kapua label Jun 24, 2021
@Coduz Coduz requested a review from lorthirk June 24, 2021 14:09
@codecov
Copy link

codecov bot commented Jun 24, 2021

Codecov Report

Merging #3339 (4271b95) into develop (af541a1) will decrease coverage by 0.00%.
The diff coverage is 50.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #3339      +/-   ##
=============================================
- Coverage      55.29%   55.29%   -0.01%     
+ Complexity       869      868       -1     
=============================================
  Files           1516     1516              
  Lines          30464    30469       +5     
  Branches        2528     2528              
=============================================
+ Hits           16845    16847       +2     
+ Misses         12690    12689       -1     
- Partials         929      933       +4     
Impacted Files Coverage Δ
.../step/definition/internal/JobStepPropertyImpl.java 48.00% <0.00%> (-4.18%) ⬇️
.../service/job/step/internal/JobStepServiceImpl.java 67.63% <50.00%> (-0.42%) ⬇️
...e/jbatch/driver/utils/JobDefinitionBuildUtils.java 91.13% <100.00%> (+0.89%) ⬆️
...nnection/internal/DeviceConnectionServiceImpl.java 67.04% <0.00%> (-2.28%) ⬇️
...pse/kapua/commons/service/internal/ServiceDAO.java 75.86% <0.00%> (-0.32%) ⬇️
...apua/job/engine/jbatch/JobEngineServiceJbatch.java 46.66% <0.00%> (ø)
.../jbatch/persistence/JPAPersistenceManagerImpl.java 31.60% <0.00%> (+1.03%) ⬆️
...kapua/job/engine/exception/JobEngineException.java 63.63% <0.00%> (+9.09%) ⬆️
...pua/job/engine/exception/JobResumingException.java 25.00% <0.00%> (+25.00%) ⬆️

Signed-off-by: Alberto Codutti <alberto.codutti@eurotech.com>
@Coduz Coduz force-pushed the feature-jobStepDefinitionPropertyRequired branch from 441c937 to 4271b95 Compare June 24, 2021 15:10
@Coduz Coduz merged commit 64dde70 into eclipse:develop Jun 24, 2021
@Coduz Coduz deleted the feature-jobStepDefinitionPropertyRequired branch June 25, 2021 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement This PR/Issue improves an part of Kapua
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants