Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invert CORS-non CORS logic in CORS Filter #3331

Merged

Conversation

lorthirk
Copy link

Fix an issue introduced by #3329 where the CORS filter would fail again for an expired or invalid Access Token

Related Issue
No related issues

Signed-off-by: Claudio Mezzasalma <claudio.mezzasalma@eurotech.com>
@lorthirk lorthirk added Bug This is a bug or an unexpected behaviour. Fix it! REST API We hope to REST everyday labels Jun 11, 2021
@lorthirk lorthirk requested a review from Coduz June 11, 2021 15:26
@codecov
Copy link

codecov bot commented Jun 11, 2021

Codecov Report

Merging #3331 (9532267) into develop (869107e) will decrease coverage by 15.11%.
The diff coverage is 0.00%.

❗ Current head 9532267 differs from pull request most recent head 6cc5737. Consider uploading reports for the commit 6cc5737 to get more accurate results
Impacted file tree graph

@@              Coverage Diff               @@
##             develop    #3331       +/-   ##
==============================================
- Coverage      54.99%   39.87%   -15.12%     
+ Complexity       791      695       -96     
==============================================
  Files           1488     1488               
  Lines          30084    30081        -3     
  Branches        2508     2508               
==============================================
- Hits           16544    11995     -4549     
- Misses         12615    17156     +4541     
- Partials         925      930        +5     
Impacted Files Coverage Δ
.../kapua/app/api/core/filter/CORSResponseFilter.java 0.00% <0.00%> (ø)
...rc/main/java/org/eclipse/kapua/KapuaException.java 0.00% <0.00%> (-100.00%) ⬇️
...c/main/java/org/eclipse/kapua/KapuaErrorCodes.java 0.00% <0.00%> (-100.00%) ⬇️
...in/java/org/eclipse/kapua/broker/BrokerDomain.java 0.00% <0.00%> (-100.00%) ⬇️
...ain/java/org/eclipse/kapua/event/ServiceEvent.java 0.00% <0.00%> (-100.00%) ⬇️
...n/java/org/eclipse/kapua/broker/BrokerDomains.java 0.00% <0.00%> (-100.00%) ⬇️
...va/org/eclipse/kapua/commons/util/SystemUtils.java 0.00% <0.00%> (-100.00%) ⬇️
...n/java/org/eclipse/kapua/model/domain/Actions.java 0.00% <0.00%> (-100.00%) ⬇️
.../java/org/eclipse/kapua/KapuaRuntimeException.java 0.00% <0.00%> (-100.00%) ⬇️
.../java/org/eclipse/kapua/model/query/SortOrder.java 0.00% <0.00%> (-100.00%) ⬇️
... and 413 more

@lorthirk lorthirk merged commit b1e15c7 into eclipse:develop Jun 15, 2021
@lorthirk lorthirk deleted the fix-corsTokenExpiredLogicInverted branch June 15, 2021 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug This is a bug or an unexpected behaviour. Fix it! REST API We hope to REST everyday
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants