Skip to content
This repository has been archived by the owner on Jan 15, 2020. It is now read-only.

Standalone GLSP Client #243

Closed
tortmayr opened this issue Apr 25, 2019 · 1 comment · Fixed by #249
Closed

Standalone GLSP Client #243

tortmayr opened this issue Apr 25, 2019 · 1 comment · Fixed by #249
Assignees
@tortmayr
Labels
client A issue that is heavily affecting the client part (Typescript) improvement Changes to already existing features

Comments

@tortmayr
Copy link
Collaborator

Currently, our client implementation is tightly coupled with Eclipse Theia and it's not possible to use the current GLSP client implementation in a standalone browser app.

We should decouple dependencies to Theia and provide a basic DiagramServer implementation in the @glsp/sprotty-client package (similar to "WebsocketDiagramServer" in base spotty)

See also #140
@tortmayr tortmayr added client A issue that is heavily affecting the client part (Typescript) improvement Changes to already existing features labels Apr 25, 2019
@tortmayr tortmayr self-assigned this Apr 25, 2019
@tortmayr tortmayr mentioned this issue Apr 29, 2019
Closed
@tortmayr
Copy link
Collaborator Author

tortmayr commented May 3, 2019

To reuse our current implementation we would have to use JSON-RPC communication over web sockets. This is currently not supported in LSP4J (only plain "normal" sockets are supported).
However, there is an open PR that introduces a Websocket Adapter to LSP4J
eclipse-lsp4j/lsp4j#314.

We should monitor this.

@tortmayr tortmayr mentioned this issue May 3, 2019
Merged
tortmayr added a commit that referenced this issue May 3, 2019
@tortmayr
Merge pull request #249 from eclipsesource/tortmayr/issue/243
3d76101 
#243 Standalone GLSP implementation
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@tortmayr tortmayr

Labels
client A issue that is heavily affecting the client part (Typescript) improvement Changes to already existing features
Projects
None yet
Milestone
No milestone
1 participant
@tortmayr