Skip to content
This repository has been archived by the owner on Jan 15, 2020. It is now read-only.

#243 Standalone GLSP implementation #249

Merged
merged 5 commits into from
May 3, 2019
Merged

#243 Standalone GLSP implementation #249

merged 5 commits into from
May 3, 2019

Conversation

tortmayr
Copy link
Collaborator

@tortmayr tortmayr commented May 3, 2019

Resolves #243:

  • Implementation of the Theia-independent GLSPWebsocketDiagramServer
  • Refactoring of GLSPTheiaDiagramServer to use a common codebase
  • server-side implementation for the WebsocketGLSPServer + minor refactoring
  • Add workflow-standalone example for testing
  • Add tasks for running the standalone example in chrome

To start the WebsocketGLSPServer for the workflow example simply add "websocket" as launch argument (java -jar workflow-example-1.2.0-SNAPSHOT-glsp.jar websocket)

(Note: Due to know issues it's currently not possible to use JSON-RPC with LSP4J and websockets out of the box (see #243). So for now the WebsocketDiagramServer does not use the JSON-RPC protocol and instead communicates with the server by simply sending action messages to a specific endpoint.
This can be addressed in a follow-up PR once eclipse-lsp4j/lsp4j#314 is merged)

@tortmayr tortmayr closed this May 3, 2019
@tortmayr tortmayr reopened this May 3, 2019
@tortmayr tortmayr changed the title Tortmayr/issue/243 #243 Standalone GLSP implementation May 3, 2019
@tortmayr
Copy link
Collaborator Author

tortmayr commented May 3, 2019

Counterpart commit for glsp-p2:
https://github.com/eclipsesource/glsp-p2/pull/3

Copy link
Collaborator

@martin-fleck-at martin-fleck-at left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested both the new standalone application (and server) and the Theia application (and server) and could not find any problems with either. All tools seem to work as expected and servers are also reacting correctly.

Fantastic change, thank you Tobi!

@tortmayr tortmayr merged commit 3d76101 into master May 3, 2019
@tortmayr tortmayr deleted the tortmayr/issue/243 branch May 3, 2019 15:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Standalone GLSP Client
2 participants