Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty string should be converted to undefined #1168

Closed
edgarmueller opened this issue Nov 16, 2018 · 1 comment
Closed

Empty string should be converted to undefined #1168

edgarmueller opened this issue Nov 16, 2018 · 1 comment
Assignees
@AlexandraBuzila
Labels
core
Milestone
2.1.0

Comments

@edgarmueller
Copy link
Contributor

Describe the bug
We should consider converting empty strings to undefined, because in case of validation errors for non-required properties it can happen that you do not get rid of the error anymore.

To Reproduce
Steps to reproduce the behavior:
Create a schema with a non-required string property with an arbitrary minLength. Delete the respective value of the property in the generated form.

Expected behavior
When clearing the form, the validation message should disappear.

Additional context
Change must be done in the core
@edgarmueller edgarmueller mentioned this issue Nov 19, 2018
Closed
@edgarmueller edgarmueller added this to the 2.1.0 milestone Nov 19, 2018
AlexandraBuzila added a commit that referenced this issue Dec 19, 2018
@AlexandraBuzila
Empty string should be converted to undefined #1168
510e72c
AlexandraBuzila added a commit to AlexandraBuzila/jsonforms that referenced this issue Dec 19, 2018
@AlexandraBuzila
Empty string should be converted to undefined eclipsesource#1168
6bed38d
edgarmueller pushed a commit that referenced this issue Dec 19, 2018
@AlexandraBuzila @edgarmueller
Empty string should be converted to undefined #1168
73f0cec
@edgarmueller
Copy link
Contributor Author

Fixed via #1197

@AlexandraBuzila AlexandraBuzila mentioned this issue Feb 5, 2019
Closed
@bennbollay bennbollay mentioned this issue Sep 28, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlexandraBuzila AlexandraBuzila

Labels
core
Projects
None yet
Milestone
2.1.0
Development

No branches or pull requests
2 participants
@edgarmueller @AlexandraBuzila