Empty string should be converted to undefined #1168 #1197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eneufeld
reviewed
Dec 19, 2018
packages/core/src/reducers/core.ts
Outdated
| @@ -145,7 +145,11 @@ export const coreReducer = ( | |||
| }; | |||
| } else { | |||
| const oldData: any = _.get(state.data, action.path); | |||
| const newData = action.updater(oldData); | |||
| let newData = action.updater(oldData); | |||
| if (newData === '' && newData.constructor.name === 'String') { | |||
There was a problem hiding this comment.
do we need the newData.constructor.name === 'String' check?
There was a problem hiding this comment.
It seems like it's not needed, since only strings and dates produce an empty string when cleared and the data type for dates is string anyway. I pushed an updated commit.
AlexandraBuzila
force-pushed
the
fix-1168
branch
from
510e72c
to
6bed38d
Compare
eneufeld
approved these changes
Dec 19, 2018
edgarmueller
approved these changes
Dec 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.