Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable rule on group does not disable contents. #1586

Closed
lucas-koehler opened this issue May 28, 2020 · 1 comment · Fixed by #1794
Closed

Disable rule on group does not disable contents. #1586

lucas-koehler opened this issue May 28, 2020 · 1 comment · Fixed by #1794

Comments

@lucas-koehler
Copy link
Contributor

Describe the bug
Using a UI schema rule to disable a group does not disable the group's contained controls.

To Reproduce
Steps to reproduce the behavior:

  1. Create UI Schema with a group containing at least one control.
  2. Add disable rule to the group
  3. Trigger the rule and check the control's state
  4. The control can still be edited

Expected behavior
The control should be disabled

Screenshots
If applicable, add screenshots to help explain your problem.

Browser (please complete the following information):

  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Used Setup (please complete the following information):

  • Framework: react
  • RendererSet: vanilla

Additional notes
Possibly the same problem also applies to other layout renderers and/or hide rules.

@sdirix
Copy link
Member

sdirix commented May 29, 2020

The problem here is that GroupLayoutRenderer should hand over its enabled prop to its children but doesn't do so. As we still use the cells system in the Vanilla renderers for all inputs we should also check all other visible and enabled props of all Vanilla renderers to hand them over appropriately.

@sdirix sdirix added this to the Backlog milestone Nov 21, 2020
sdirix pushed a commit that referenced this issue Nov 22, 2021
- Pass enabled prop to individual group elements (React Vanilla)
- Implement enabled prop for Radiogroup (React Vanilla & Material)

Closes #1586
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants