Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable group elements on group disable rule #1794

Merged
merged 1 commit into from
Nov 22, 2021
Merged

Disable group elements on group disable rule #1794

merged 1 commit into from
Nov 22, 2021

Conversation

max-elia
Copy link
Contributor

@max-elia max-elia commented Aug 3, 2021

To Reproduce:

export const schema = {
  type: 'object',
  properties: {
    name: {
      type: 'string',
      minLength: 3,
      description: 'Please enter your name'
    },
    birthDate: {
      type: 'string',
      format: 'date'
    }
  }
};

export const uischema = {
  type: 'Group',
  label: 'My Group',
  elements: [
    {
      type: 'Control',
      label: 'Name',
      scope: '#/properties/name'
    },
    {
      type: 'Control',
      label: 'Birth Date',
      scope: '#/properties/birthDate'
    }
  ],
  options: {
    readonly: true
  },
};

Signed-off-by: Max Elia Schweigkofler max_elia@hotmail.de

@coveralls
Copy link

coveralls commented Aug 3, 2021

Coverage Status

Coverage increased (+0.008%) to 88.988% when pulling 122ccb3 on max-elia:disable-group-elements into 81e4dd6 on eclipsesource:master.

- Pass enabled prop to individual group elements (vanilla)
- Implement enabled prop for Radiogroup (vanilla & material)
Closes #1586

Signed-off-by: Max Elia Schweigkofler <max_elia@hotmail.de>
@sdirix sdirix requested a review from TheZoker November 4, 2021 08:39
Copy link
Contributor

@TheZoker TheZoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested all changed elements and the disabled prop seems to work fine, thanks! 👍

Copy link
Member

@sdirix sdirix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@sdirix sdirix merged commit 988f282 into eclipsesource:master Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable rule on group does not disable contents.
4 participants