Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MUI Autocomplete has no endAdornment arrow #1965

Closed
lovervoorde opened this issue Jun 27, 2022 · 1 comment · Fixed by #1982
Closed

MUI Autocomplete has no endAdornment arrow #1965

lovervoorde opened this issue Jun 27, 2022 · 1 comment · Fixed by #1982
Assignees
@LukasBoll

Comments

@lovervoorde
Copy link

Is your feature request related to a problem? Please describe.

The autocomplete renderer does not have a a downwards pointing arrow to indicate that clicking it will open a dropdown.

Describe the solution you'd like

A downward arrow at the left of the autocomplete, as is the default behaviour for the MUI autocomplete.

Describe alternatives you've considered

Creating a custom autocomplete renderer (this seems like overkill)

Framework

React

RendererSet

Material

Additional context

No response
@sdirix
Copy link
Member

sdirix commented Jun 28, 2022

ToDo:

  • Check all enum renderers whether they show this adornment, they seem to be shown by default for Select and Autocomplete in Material UI

LukasBoll added a commit to LukasBoll/jsonforms that referenced this issue Jul 19, 2022
@LukasBoll
change MuiAutocomplete from Input to Textfield
41b773c 
closes eclipsesource#1965

Signed-off-by: Lukas Boll lukas-bool@web.de
LukasBoll added a commit to LukasBoll/jsonforms that referenced this issue Jul 19, 2022
@LukasBoll
change MuiAutocomplete from Input to Textfield
bf93b7a 
closes eclipsesource#1965

Signed-off-by: Lukas Boll lukas-bool@web.de
@LukasBoll LukasBoll mentioned this issue Jul 19, 2022
Merged
LukasBoll added a commit to LukasBoll/jsonforms that referenced this issue Jul 20, 2022
@LukasBoll
change MuiAutocomplete from Input to Textfield
3351b89 
closes eclipsesource#1965

Signed-off-by: Lukas Boll lukas-bool@web.de
sdirix pushed a commit that referenced this issue Jul 24, 2022
@LukasBoll
Use TextField in React Material Autocomplete
40dfe40 
Switch from 'Input' to 'TextField' in MuiAutocomplete. This change allows the clear
button and end adornment of the 'Autocomplete' being rendered in the 'TextField'.

Closes #1965

Signed-off-by: Lukas Boll lukas-bool@web.de
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LukasBoll LukasBoll

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

change MuiAutocomplete from Input to Textfield LukasBoll/jsonforms
3 participants
@sdirix @LukasBoll @lovervoorde