change MuiAutocomplete from Input to Textfield #1982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdirix
requested changes
Jul 19, 2022
| <MuiAutocomplete | ||
| {...props} | ||
| isValid={isValid} | ||
| visible={visible} |
There was a problem hiding this comment.
visibleis already handed over via the...propsso we don't need to do this explicitely.- There is no need to determine and hand over
isValidhere. Just do the calculation within theMuiAutocomplete.
There was a problem hiding this comment.
Oh, yes visible is unnecessary.
I added isValid, because its part of the EnumCellProps interface.
Comment on lines
52
to
53
| isValid={isValid} | ||
| visible={visible} |
closes eclipsesource#1965 Signed-off-by: Lukas Boll lukas-bool@web.de
|
I checked the control options and they are working. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1965