Improve performance #1655
Merged
Improve performance #1655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdirix
force-pushed
the
improve-performance
branch
4 times, most recently
from
5b9ee56
to
7c92418
Compare
AlexandraBuzila
force-pushed
the
improve-performance
branch
2 times, most recently
from
0ac4221
to
d582521
Compare
sdirix
force-pushed
the
improve-performance
branch
2 times, most recently
from
e59adb2
to
5c870ea
Compare
Adds a new action (UPDATE_CORE) which updates the state only when there are actual changes. This action is now used in React to handle incoming props. Therefore changing JsonForms props behaves much more intuitively. This also allows to use JsonForms in a 'controlled' style without a performance penalty.
* Avoid unnecessary initialization calls by initializing reducers with functions * Avoid updating context value when there are no changes * Memoize tester evaluations * Memoize uischema evaluations * Use customized 'areEqual' instead of 'isEqual'
Move onChange handling from JsonFormsDispatch to StateProvider as it also manages the source of truth, i.e. the JsonForms core containing the emitted data and errors. Also use `useEffect` instead of `useLayoutEffect` as the latter one is not needed here. This also removes warnings when using JsonForms in SSR settings.
As a new schema is set by the the 'SET_SCHEMA' action the data needs to be revalidated. This is now done.
sdirix
force-pushed
the
improve-performance
branch
from
5c870ea
to
f289fe3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid unnecessary initialization calls in React
Use the initialization function of 'useReducer' to avoid unnecessary dispatching of init actions whose result is ignored anyway.
Make sure validation is run on set schema
Only update state with changed properties of JsonFormsCore
Instead of calling the INIT action when one of the core properties changes, introduce a new action (UPDATE_CORE) which updates only the changed properties in the state.