Fix useLayoutEffect warning for SSR with React #1656
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We tried using the JsonForms component when doing server side rendering with react using
ReactDomServer and because of the use of the useLayoutEffect hook, we would get a warning of 'Warning: useLayoutEffect does nothing on the server, because its effect cannot be encoded into the server renderer's output format...' all the time.
This pull request removes the warning by using useEffect instead if we are not in the browser.
Thank you!