fix: make NumberCell for Vanilla Renderer show 0 #1658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you very much for the contribution! Could you also add a testcase? |
sdirix
requested changes
Dec 1, 2020
| return ( | ||
| <input | ||
| type='number' | ||
| step='0.1' | ||
| value={data || ''} | ||
| value={value} |
There was a problem hiding this comment.
Suggested change
| value={value} | |
| value={data ?? ''} |
There was a problem hiding this comment.
True, thanks! I am making the change now.
There was a problem hiding this comment.
Also I would love to add a testcase, but for the moment I am not familiar with how enzyme works, or testing for react components in general, so it might take me some time 😅
The React Vanilla NumberCell now correctly displays the number 0 instead of an empty string. Co-authored-by: Stefan Dirix <sdirix@eclipsesource.com>
sdirix
approved these changes
Dec 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using a default value of 0 for a number cell with vanilla renderers, the input is shown with an empty string. This is a quick fix for it.