Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Vanilla IntegerCell not rendering zero #1916

Merged
merged 1 commit into from
Apr 11, 2022
Merged

Fix Vanilla IntegerCell not rendering zero #1916

merged 1 commit into from
Apr 11, 2022

Conversation

nmay231
Copy link
Contributor

@nmay231 nmay231 commented Apr 10, 2022

Basically the same thing as #1658.

@CLAassistant
Copy link

CLAassistant commented Apr 10, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 84.29% when pulling 492ca33 on nmay231:fix-0-render into 7e5ac13 on eclipsesource:master.

sdirix
sdirix approved these changes Apr 11, 2022
View reviewed changes
Copy link
Member

@sdirix sdirix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Definitely makes sense to me!

@sdirix sdirix added this to the 3.0 milestone Apr 11, 2022
@sdirix sdirix merged commit 23e1a55 into eclipsesource:master Apr 11, 2022
@nmay231 nmay231 deleted the fix-0-render branch April 11, 2022 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdirix sdirix sdirix approved these changes

Assignees
No one assigned
Labels
react vanilla
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.
4 participants
@nmay231 @CLAassistant @coveralls @sdirix