Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes group's label being reformatted with startCase #1701

Merged
merged 1 commit into from
Mar 10, 2021
Merged

Fixes group's label being reformatted with startCase #1701

merged 1 commit into from
Mar 10, 2021

Conversation

sifthedog
Copy link
Contributor

No description provided.

@CLAassistant
Copy link

CLAassistant commented Feb 23, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.003%) to 88.579% when pulling cbd7ce3 on sifthedog:fixes/group-label into e2b6911 on eclipsesource:master.

sdirix
sdirix reviewed Mar 9, 2021
View reviewed changes
Copy link
Member

@sdirix sdirix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This certainly improves the current situation but we probably shouldn't change the label unconditionally, i.e. this still overrides the label which is manually set on a group detail.

@sdirix sdirix added this to the 2.5.1 milestone Mar 10, 2021
@sdirix sdirix linked an issue Mar 10, 2021 that may be closed by this pull request
Special characters being removed from 'Group' label #1699
Closed
@sdirix sdirix merged commit 9c2aee0 into eclipsesource:master Mar 10, 2021
@sdirix sdirix mentioned this pull request Mar 11, 2021
Closed
@sdirix
Copy link
Member

sdirix commented Mar 11, 2021

I opened a follow up: #1712

@sifthedog
Copy link
Contributor Author

@sdirix need a hand with the follow up? Let me know if I can help in any way.

@sdirix
Copy link
Member

sdirix commented Mar 15, 2021

@sdirix need a hand with the follow up? Let me know if I can help in any way.

Sure that would be great ;) The main problem here is that findUISchema doesn't indicate whether it generated or found the ui schema. In the latter case we should not modify it. Also any change should be backwards compatible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdirix sdirix sdirix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.5.1
Development

Successfully merging this pull request may close these issues.

Special characters being removed from 'Group' label
4 participants
@sifthedog @CLAassistant @coveralls @sdirix