Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't modify user-schemas in Material Object Renderer #1712

Closed
sdirix opened this issue Mar 11, 2021 · 0 comments · Fixed by #1871
Closed

Don't modify user-schemas in Material Object Renderer #1712

sdirix opened this issue Mar 11, 2021 · 0 comments · Fixed by #1871
Labels
bug material react
Milestone
3.0

Comments

@sdirix
Copy link
Member

sdirix commented Mar 11, 2021

Description
A detail ui schema can be set for objects. The Material Object renderer should not modify user-given ui schemas.

To Reproduce

  1. Specify a detail ui schema with a label for an object control
  2. The Material Object renderer will modify the label when the object control is not on the root path

Expected behavior
The Material Object renderer should not modify user-given ui schemas.

Used Setup:

  • Framework: [react]
  • RendererSet: [material]

Additional context
Follow up of #1701
@sdirix sdirix added this to the next milestone Mar 11, 2021
This was referenced Mar 11, 2021
Merged
Closed
LukasBoll added a commit to LukasBoll/jsonforms that referenced this issue Jan 15, 2022
@LukasBoll
Don't modify user-schemas in Material Object Renderer
0655493 
closes eclipsesource#1712

Signed-off-by: Lukas Boll lukas-bool@web.de
@LukasBoll LukasBoll mentioned this issue Jan 15, 2022
Merged
LukasBoll added a commit to LukasBoll/jsonforms that referenced this issue Jan 24, 2022
@LukasBoll
Don't modify user-schemas in Material Object Renderer
9690c66 
closes eclipsesource#1712

Signed-off-by: Lukas Boll lukas-bool@web.de
Co-authored-by: Max Elia Schweigkofler <max_elia@hotmail.de> (+1 squashed commits)
LukasBoll added a commit to LukasBoll/jsonforms that referenced this issue Feb 7, 2022
@LukasBoll
Don't modify user-schemas in Material Object Renderer
1b6de6e 
closes eclipsesource#1712

Signed-off-by: Lukas Boll lukas-bool@web.de
Co-authored-by: Max Elia Schweigkofler <max_elia@hotmail.de> (+1 squashed commits)
LukasBoll added a commit to LukasBoll/jsonforms that referenced this issue Feb 8, 2022
@LukasBoll
Don't modify user-schemas in Material Object Renderer
c874f4c 
closes eclipsesource#1712

Signed-off-by: Lukas Boll lukas-bool@web.de
Co-authored-by: Max Elia Schweigkofler <max_elia@hotmail.de> (+1 squashed commits)
LukasBoll added a commit to LukasBoll/jsonforms that referenced this issue Feb 28, 2022
@LukasBoll
Don't modify user-schemas in Material Object Renderer
9fc2ed9 
closes eclipsesource#1712

Signed-off-by: Lukas Boll lukas-bool@web.de
LukasBoll added a commit to LukasBoll/jsonforms that referenced this issue Apr 2, 2022
@LukasBoll
Don't modify user-schemas in Material Object Renderer
77327d5 
closes eclipsesource#1712

Signed-off-by: Lukas Boll lukas-bool@web.de
sdirix pushed a commit that referenced this issue Apr 6, 2022
@LukasBoll
Preserve schemas in React Material Object Renderer
67b036e 
The React Material object renderer supports generating a group layout for its contained
properties. The label of the group layout was unconditionally set, overwriting user
specified 'detail' and registered UI schemas. This is now fixed.

closes #1712

Signed-off-by: Lukas Boll lukas-bool@web.de
@sdirix sdirix modified the milestones: next, 3.0 Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug material react
Projects
None yet
Milestone
3.0
Development

Successfully merging a pull request may close this issue.

Don't modify user-schemas in Material Object Renderer LukasBoll/jsonforms
1 participant
@sdirix