Don't modify user-schemas in Material Object Renderer #1871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max-elia
approved these changes
Jan 21, 2022
LukasBoll
force-pushed
the
fix/modify_user_schemal
branch
from
f469aec
to
9690c66
Compare
|
Thanks! I updated the code accordingly. |
sdirix
requested changes
Feb 1, 2022
| @@ -33,7 +33,8 @@ export const Generate: { | |||
| jsonSchema: JsonSchema, | |||
| layoutType?: string, | |||
| prefix?: string, | |||
| rootSchema?: JsonSchema | |||
| rootSchema?: JsonSchema, | |||
| label?: string | |||
| const detailUiSchema = useMemo( | ||
| () => | ||
| findUISchema( | ||
| uischemas, | ||
| schema, | ||
| uischema.scope, | ||
| path, | ||
| 'Group', | ||
| () => Generate.uiSchema(schema, 'Group', undefined, undefined, label), |
There was a problem hiding this comment.
I would prefer assigning the label as part of the generator
LukasBoll
force-pushed
the
fix/modify_user_schemal
branch
2 times, most recently
from
1b6de6e
to
c874f4c
Compare
sdirix
reviewed
Feb 22, 2022
Comment on lines
65
to
66
| if (isEmpty(path)) { | ||
| detailUiSchema.type = 'VerticalLayout'; |
There was a problem hiding this comment.
We should also remove this modification ;)
LukasBoll
force-pushed
the
fix/modify_user_schemal
branch
from
c874f4c
to
9fc2ed9
Compare
sdirix
reviewed
Mar 29, 2022
closes eclipsesource#1712 Signed-off-by: Lukas Boll lukas-bool@web.de
LukasBoll
force-pushed
the
fix/modify_user_schemal
branch
from
d59dda6
to
77327d5
Compare
|
Thank you, I added your suggestion! |
sdirix
approved these changes
Apr 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't modify user-schemas in Material Object Renderer
closes #1712
Signed-off-by: Lukas Boll lukas-bool@web.de