Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update React enum options on i18n changes #1879

Merged
merged 2 commits into from
Feb 3, 2022
Merged

Update React enum options on i18n changes #1879

merged 2 commits into from
Feb 3, 2022

Conversation

TheZoker
Copy link
Contributor

Until now select options where not translated after changing the translation, this should fix this

@coveralls
Copy link

coveralls commented Jan 26, 2022 •
edited
Loading

Coverage Status

Coverage remained the same at 84.242% when pulling b1ed487 on TheZoker:fix-useMemo into 8c3b626 on eclipsesource:master.

@sdirix sdirix mentioned this pull request Feb 1, 2022
Merged
sdirix
sdirix approved these changes Feb 3, 2022
View reviewed changes
Copy link
Member

@sdirix sdirix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes!

@sdirix sdirix merged commit 63b40d1 into eclipsesource:master Feb 3, 2022
@sdirix sdirix added the react label Feb 3, 2022
@sdirix sdirix changed the title Fix useMemo() for translation props Update React enum options on i18n changes Feb 3, 2022
@TheZoker TheZoker deleted the fix-useMemo branch February 3, 2022 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdirix sdirix sdirix approved these changes

Assignees
No one assigned
Labels
react
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TheZoker @coveralls @sdirix