Rework i18n support in JSON Forms core #1825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Labels, descriptions and error messages can now be translated via special translation functions handed over to JSON Forms. The translations are automatically handed within the default mapping functions and are therefore available in all renderer sets. This includes a key-determination algorithm, allowing to either rely on using labels as keys or specifying 'i18n' keys in UI Schema options or directly within the JSON Schema. Errors are handled separately to allow for maximum flexibility. Includes test cases for the most common mapping functions. Also AJV is set to non-strict by default to not throw errors when handing over JSON Schemas containing 'i18n' keys.
|
Tested and reviewed the code. |
max-elia
approved these changes
Oct 27, 2021
|
@sdirix could you put an example here with i18n keys in the schema or uischema? I don't find the right way of setting this in the case of |
|
@andresgutgon There is an example in the Vue2-Vuetify renderer set for the 'basic' example (see under the 'schema' tab) https://jsonforms-vuetify-renderers.netlify.app/#/example/basic That has i18n keys and also an enum, maybe that will be helpful. |
|
The enums actually have a bug right now in the React Material renderers (Angular and Vue are fine). They will render correctly with the first locale selection but will not update their labels when the translator is changed without an additional schema change. This will be fixed here: #1879 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Labels, descriptions and error messages can now be translated via
special translation functions handed over to JSON Forms.
The translations are automatically handed within the default
mapping functions and are therefore available in all renderer sets.
This includes a key-determination algorithm, allowing to either rely
on using labels as keys or specifying 'i18n' keys in UI Schema options
or directly within the JSON Schema. Errors are handled separately to
allow for maximum flexibility.
Includes test cases for the most common mapping functions.
Also AJV is set to non-strict by default to not throw errors when
handing over JSON Schemas containing 'i18n' keys.