Skip to content

Commit

Permalink
[Coverage] Uncomment inline, use mainnet dep
Browse files Browse the repository at this point in the history
The last commit tested Move code to 100% coverage, which
was only possible by commenting out inline keywords and
using a non-mainnet dependency per:

aptos-labs/aptos-core#9154
aptos-labs/aptos-core#9181
  • Loading branch information
alnoki committed Jul 28, 2023
1 parent 945273d commit 12730d8
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 5 deletions.
7 changes: 4 additions & 3 deletions src/move/econia/Move.toml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,8 @@ integrator = "0x4567"

[dependencies.AptosFramework]
git = "https://github.com/aptos-labs/aptos-core.git"
# You may need to change this to `main` to run event unit tests per
# https://github.com/aptos-labs/aptos-core/pull/9181
rev = "main"
# You may need to change this to `main` to run event unit tests, pending
# https://github.com/aptos-labs/aptos-core/pull/9181 merging from `main`
# into `mainnet`.
rev = "mainnet"
subdir = "aptos-move/framework/aptos-framework"
2 changes: 1 addition & 1 deletion src/move/econia/sources/market.move
Original file line number Diff line number Diff line change
Expand Up @@ -2733,7 +2733,7 @@ module econia::market {
///
/// * `Option<u8>`: An optional cancel reason, if the order needs
/// to be cancelled.
/*inline*/ fun get_cancel_reason_option_for_market_order_or_swap(
inline fun get_cancel_reason_option_for_market_order_or_swap(
self_match_taker_cancel: bool,
base_traded: u64,
max_base: u64,
Expand Down
2 changes: 1 addition & 1 deletion src/move/econia/sources/user.move
Original file line number Diff line number Diff line change
Expand Up @@ -2864,7 +2864,7 @@ module econia::user {
/// Emit a `FillEvent` for the market account of the maker
/// associated with a fill, if market event handles exist for the
/// indicated market account.
/*inline*/ fun emit_maker_fill_event(
inline fun emit_maker_fill_event(
event_ref: &FillEvent
) acquires MarketEventHandles {
let maker = event_ref.maker;
Expand Down

0 comments on commit 12730d8

Please sign in to comment.