-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug][CLI] Coverage testing is broken for inline functions #9154
Labels
bug
Something isn't working
stale-exempt
Prevents issues from being automatically marked and closed as stale
Comments
alnoki
added a commit
to econia-labs/econia
that referenced
this issue
Jul 19, 2023
The inline modifier needs to be commented out for coverage testing per aptos-labs/aptos-core#9154
alnoki
added a commit
to econia-labs/econia
that referenced
this issue
Jul 20, 2023
alnoki
added a commit
to econia-labs/econia
that referenced
this issue
Jul 20, 2023
bogberry
pushed a commit
to econia-labs/econia
that referenced
this issue
Jul 21, 2023
* Remove cancel event for limit order with full fill * Link PR in changelog, update docs, inline keywords The inline modifier needs to be commented out for coverage testing per aptos-labs/aptos-core#9154 * Update remaining size, enable posts below min size * Comment out inline directive for coverage testing Per aptos-labs/aptos-core#9154 * [Coverage] Uncomment inline keyword Per aptos-labs/aptos-core#9154 * Alphabetize view func index
sausagee
added
the
stale-exempt
Prevents issues from being automatically marked and closed as stale
label
Jul 22, 2023
alnoki
added a commit
to econia-labs/econia
that referenced
this issue
Jul 24, 2023
alnoki
added a commit
to econia-labs/econia
that referenced
this issue
Jul 28, 2023
The last commit tested Move code to 100% coverage, which was only possible by commenting out inline keywords and using a non-mainnet dependency per: aptos-labs/aptos-core#9154 aptos-labs/aptos-core#9181
elliottdehn
pushed a commit
to econia-labs/econia
that referenced
this issue
Aug 1, 2023
elliottdehn
pushed a commit
to econia-labs/econia
that referenced
this issue
Aug 1, 2023
The last commit tested Move code to 100% coverage, which was only possible by commenting out inline keywords and using a non-mainnet dependency per: aptos-labs/aptos-core#9154 aptos-labs/aptos-core#9181
alnoki
added a commit
to econia-labs/econia
that referenced
this issue
Oct 26, 2023
alnoki
added a commit
to econia-labs/econia
that referenced
this issue
Oct 26, 2023
alnoki
added a commit
to econia-labs/econia
that referenced
this issue
Oct 26, 2023
alnoki
added a commit
to econia-labs/econia
that referenced
this issue
Oct 26, 2023
alnoki
added a commit
to econia-labs/econia
that referenced
this issue
Oct 28, 2023
alnoki
added a commit
to econia-labs/econia
that referenced
this issue
Oct 28, 2023
alnoki
added a commit
to econia-labs/econia
that referenced
this issue
Nov 6, 2023
alnoki
added a commit
to econia-labs/econia
that referenced
this issue
Nov 6, 2023
alnoki
added a commit
to econia-labs/econia
that referenced
this issue
Nov 6, 2023
alnoki
added a commit
to econia-labs/econia
that referenced
this issue
Nov 18, 2023
alnoki
added a commit
to econia-labs/econia
that referenced
this issue
Nov 18, 2023
alnoki
added a commit
to econia-labs/econia
that referenced
this issue
Mar 15, 2024
alnoki
added a commit
to econia-labs/econia
that referenced
this issue
Mar 15, 2024
alnoki
added a commit
to econia-labs/emojicoin-dot-fun
that referenced
this issue
May 4, 2024
4 tasks
4 tasks
alnoki
added a commit
to econia-labs/emojicoin-dot-fun
that referenced
this issue
May 19, 2024
alnoki
added a commit
to econia-labs/emojicoin-dot-fun
that referenced
this issue
May 19, 2024
Merged
3 tasks
2 tasks
alnoki
added a commit
to econia-labs/emojicoin-dot-fun
that referenced
this issue
Jun 3, 2024
alnoki
added a commit
to econia-labs/emojicoin-dot-fun
that referenced
this issue
Jun 3, 2024
4 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
stale-exempt
Prevents issues from being automatically marked and closed as stale
@0xjinn @banool @davidiw @gregnazario @movekevin @wrwg
Summary
The coverage tool does not work for inline functions:
Steps to reproduce
Note that pending the resolution of #7295 this will probably take on the order of 10 minutes to complete:
For this commit, where the
inline
keyword is commented out, there is no issue comparing against source:aptos move coverage source --module user
aptos move coverage source --module market
However, when the
inline
keyword is uncommented (the only change in commit econia-labs/econia@464a7c9b), the coverage tool reports different coverage statistics:(Again, pending the resolution of #7295 this will probably take on the order of 10 minutes to complete):
The tool also panics, inconsistently, when trying to compare against source:
There is no such panic in the other module, though its coverage statistics have been reported incorrectly:
The text was updated successfully, but these errors were encountered: