Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ECO-1564][Coverage] Make package immutable, uncomment inline keyword #67

Merged
merged 3 commits into from
May 19, 2024

Conversation

alnoki
Copy link
Member

@alnoki alnoki commented May 19, 2024

Description

  1. Make package immutable
  2. Uncomment the inline keyword which was commented out during development,
    such that 100% coverage could be achieved. See
    [Bug][CLI] Coverage testing is broken for inline functions aptos-labs/aptos-core#9154 for more.
  3. Re-build docs.

Testing

All tests still pass, but now at 95.94% coverage compared with 100% before uncommenting inline keyword.

From in src/move/emojicoin_dot_fun:

git ls-files | entr -c aptos move test --coverage --dev

Published on testnet under single signer account:
https://explorer.aptoslabs.com/account/0xb11b48d9e8cece3b50a48996704bd1476caa761dfb84de38f9f8d1e136c8fa89/modules/code/emojicoin_dot_fun?network=testnet

Multisig account:
https://explorer.aptoslabs.com/account/0x761e2d91c9e986557b04bdda55b6b8ccf72402ec3b6681504c29f12a55d45e69/modules/code/emojicoin_dot_fun?network=testnet

Checklist

  • Did you update relevant documentation (if applicable)?
  • Did you add tests to cover new code or a fixed issue (if applicable)?
  • Did you update the changelog (if applicable)?
  • Did you check all checkboxes from the linked Linear task (if applicable)?

Copy link

vercel bot commented May 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
emojicoin-dot-fun ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 19, 2024 4:31am

@alnoki
Copy link
Member Author

alnoki commented May 19, 2024

@alnoki alnoki changed the title [ECO-1564] Add final audit prep [ECO-1564][Coverage] Make package immutable, uncomment inline keyword May 19, 2024
@alnoki alnoki requested a review from xbtmatt May 19, 2024 00:36
@alnoki alnoki force-pushed the ECO-1599 branch 2 times, most recently from fe6ce39 to 8022602 Compare May 19, 2024 04:04
@alnoki alnoki force-pushed the ECO-1564 branch 2 times, most recently from 144814f to ddab2c2 Compare May 19, 2024 04:09
Base automatically changed from ECO-1599 to main May 19, 2024 04:28
@alnoki alnoki marked this pull request as ready for review May 19, 2024 04:44
@alnoki alnoki merged commit ea08777 into main May 19, 2024
6 checks passed
@alnoki alnoki deleted the ECO-1564 branch May 19, 2024 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants