Handle ErrorResponse in ping #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1st1
approved these changes
Nov 18, 2022
fantix
added a commit
that referenced
this pull request
Nov 23, 2022
* Handle IdleSessionTimeoutError in blocking client reconnect
fantix
added a commit
that referenced
this pull request
Nov 23, 2022
Changes ======= * Output pretty error if possible (#399) (by @fantix in a2bec18 for #399) * Codegen: allow providing a path after --file (#400) (by @fantix in 6bce57e for #400) Fixes ===== * Handle ErrorResponse in ping (#393) (by @fantix in 8b28947 for #393) * Disallow None in elements of array argument (by @fantix in 26fb6d8) Docs ==== * Remove references to unix-domain sockets (by @quinchs in 4b8bec6)
Merged
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves the error output when an
ErrorResponseis received uponSyncafter the client connection is idle over_ping_wait_time. The error was:Traceback (most recent call last): File "edgedb/blocking_client.py", line 155, in raw_query await self._protocol._sync() File "edgedb/protocol/protocol.pyx", line 712, in _sync File "edgedb/protocol/protocol.pyx", line 1071, in edgedb.protocol.protocol.SansIOProtocol.fallthrough edgedb.errors.ProtocolError: unexpected message type 'E'But this cannot explain or fix the server issue why anErrorResponseis returned uponSync.The server will send an
IdleSessionTimeoutErrorwhen killing idle connections:https://github.com/edgedb/edgedb/blob/2b426dccf6f2c4af60915a8ee47a41eff1f6a00c/edb/server/protocol/binary.pyx#L371-L378
Depending on the idle time (comparing to socket write timeout), the blocking client may still receive this error on
ping. In this case, we should just reconnect and recover.Refs #365