Codegen: allow providing a path after --file #400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is not a breaking change; `--file` itself without a path works the same way as it was before.
fantix
changed the title
1st1
approved these changes
Nov 21, 2022
fantix
added a commit
that referenced
this pull request
Nov 23, 2022
This is not a breaking change; `--file` itself without a path works the same way as it was before. * Also use color in codegen output
fantix
added a commit
that referenced
this pull request
Nov 23, 2022
Changes ======= * Output pretty error if possible (#399) (by @fantix in a2bec18 for #399) * Codegen: allow providing a path after --file (#400) (by @fantix in 6bce57e for #400) Fixes ===== * Handle ErrorResponse in ping (#393) (by @fantix in 8b28947 for #393) * Disallow None in elements of array argument (by @fantix in 26fb6d8) Docs ==== * Remove references to unix-domain sockets (by @quinchs in 4b8bec6)
Merged
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not a breaking change;
--fileitself without a path works the same way as it was before.Fixes #396
So now you can do:
--filefor<project_dir>/generated_edgeql.pyor<project_dir>/generated_async_edgeql.py--file my/generated/file.pyformy/generated/file.py(As an implementation detail side effect, you can provide
--filemultiple times to have multiple identical copies in different places.)