Erup 5 latest #22
Closed
Erup 5 latest #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ Reverted the bonding duration to 2 weeks (was changed to 24 weeks) + Reverted slah duration to 1 week (was changed to 6 weeks) + Changed the vote locking period back to 1 week. This one was changed from 1 week to 1 day on last upgrade, as an unwanted result of changing the voting enactment time. The change is probably uncontroversial (the parameters now just don't make sense), but would need to be mentioned when deploying launching the upgrade for good order. + Reverted GAS_PER_SECOND to 8_000_000, which was the previous value intended for mainnet instead of 40_000_000. The EVM is untested in production and there isn't much value in deploying with a massive gas capacity before getting any usage. We can scale this number up as we get more confident over time. + Removed the dumplicate definition of EthApi.There were two identical enum definitions in different files, with one mapping all elements to the other on funcction call to avoid type mismatch. Why it was done that way is a mystery, but functionalities shouldn't be affected by the change. It needs to be tested for good order.
+ Fixed warnings
re-enabled wasmtime.
|
… output, now displaying versionname#git commit
tests for burp branch
Merged
|
Cherry picked in #28 and merged already. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
erup-5-latest pr
Runtime migrations are going throw, chain produces blocks after upgrade