v4.0.0 RC1 #30
v4.0.0 RC1 #30
Conversation
+ Reverted the bonding duration to 2 weeks (was changed to 24 weeks) + Reverted slah duration to 1 week (was changed to 6 weeks) + Changed the vote locking period back to 1 week. This one was changed from 1 week to 1 day on last upgrade, as an unwanted result of changing the voting enactment time. The change is probably uncontroversial (the parameters now just don't make sense), but would need to be mentioned when deploying launching the upgrade for good order. + Reverted GAS_PER_SECOND to 8_000_000, which was the previous value intended for mainnet instead of 40_000_000. The EVM is untested in production and there isn't much value in deploying with a massive gas capacity before getting any usage. We can scale this number up as we get more confident over time. + Removed the dumplicate definition of EthApi.There were two identical enum definitions in different files, with one mapping all elements to the other on funcction call to avoid type mismatch. Why it was done that way is a mystery, but functionalities shouldn't be affected by the change. It needs to be tested for good order.
+ Fixed warnings
re-enabled wasmtime.
+Tentatively added all migrations excepted #9507. +The voters bag list logic cannot work with the current currency denomination and will either require and adapation of substrate, or some partial removal. This is a current blcking point of the release.
… to the absurd number of decimal points for the token related to its supply. +Removed additional 3rd party dependencies. +Added logic to credit the account of the web3 foundation.
+Added a new testnet configuration specs (all bootnodes, staking authorities and sudo now to be updated). + Added a compilation mode for fast runtime. + Fixed the issues with double address in genesis in for the dev configuration. + Fixed the treasury reward pallet tests. + Added ongoing changes in the typescript testsuite.
+Fixed the fast-runtime feature
+Lowest endowment for v46 +Reverted the maximum number of nominators per validator to 128
+ Tentatively added the final address for the w3f refund (waiting for offical confirmation).
+ set version number according to the substrate version. + recovered the mainnet genesis specs + fixed pallet -unit-testing testing workflow.
|
ShankarWarang
requested review from
JelliedOwl,
Depth-Hoar,
pranavcpawar and
Prathamesh-Nate
|
This PR is intended to re-propose the previously merged but reverted PR #28. |
There was a problem hiding this comment.
As far as I can see, it all looks reasonable. But it's a massive change and it's probably impossible for anyone to review everything here. We know that this version seem to be working in the testnet, including apparently making the migrations correctly.
I've also double-checked that fees and staking rewards still look reasonable on the testnet after the runtime upgrade.
I can't guarantee I haven't missed something, but I'd go with this version.
No more confusing terms like 'ERUP5', just
v4.0.0to follow the substrate version!Substrate v4.(Node v4.0.0 pre-release will be made after the merging to use it for the public testnet. The pre-release will be converted into a release when the upgrade is proposed on-chain to the community.)