Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add german translation #136

Merged
merged 2 commits into from
Apr 4, 2018
Merged

Add german translation #136

merged 2 commits into from
Apr 4, 2018

Conversation

tofi86
Copy link
Contributor

@tofi86 tofi86 commented Apr 2, 2018

Add german translation files.

Yes/No buttons in Dialogs are still in French though, see #128 (comment)

@tofi86
Copy link
Contributor Author

tofi86 commented Apr 2, 2018

Dear maintainers: Please ping me a couple of days before the next public release / every public release after its feature-freeze so I can update the german language file in time!

@llemeurfr
Copy link
Contributor

Thanks a lot Tobias, for these translations.
Note: I see that a TravisCI lint check has failed...
Ok, we'll ping you (as much as we can trigger our memory).
Don't hesitate to give us info about your use of Readium Desktop.

@tofi86
Copy link
Contributor Author

tofi86 commented Apr 2, 2018

@llemeurfr yeah, just noted a linting error. Will fix it.

@danielweck
Copy link
Member

Hello Tobias, I believe Pull Requests must target the 'develop' branch, not 'master' (which is used to tag releases).

@tofi86 tofi86 changed the base branch from master to develop April 2, 2018 18:20
@tofi86
Copy link
Contributor Author

tofi86 commented Apr 2, 2018

Hi Daniel, alright, I changed target to develop. Travis running again, but shouldn't be a problem as master and devlop seem to be even. Will do that for the other PR's as well.

You could add a GitHub Contributing file to state this info.

@JayPanoz
Copy link

JayPanoz commented Apr 3, 2018

You could add a GitHub Contributing file to state this info.

See also PR templates e.g. the one for readium-css, with a checklist at the very beginning to make sure everything is OK. Not perfect but it’s at least another safety net.

@clebeaupin clebeaupin merged commit 260e856 into edrlab:develop Apr 4, 2018
@tofi86 tofi86 deleted the german-translation branch April 4, 2018 16:59
@tofi86
Copy link
Contributor Author

tofi86 commented Apr 4, 2018

Thanks for merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants