Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Google Play podcast tags #7

Open
eduncan911 opened this issue May 13, 2017 · 3 comments
Open

Add Google Play podcast tags #7

eduncan911 opened this issue May 13, 2017 · 3 comments

Comments

@eduncan911
Copy link
Owner

This ticket is to enhance the library to generate GooglePlay Podcast tags to the feeds.

https://support.google.com/googleplay/podcasts/answer/6260341#tags

Required additional tag, at a Minimal, at the root:

The following is required by GooglePlay, for authorization of the podcast submission.

  • itunes:author or googleplay:author
  • itunes:email or googleplay:email (must be valid email, to get an Authorization link)

This means we will have to make these requirements in this library, possibly from the podcast.New(...) signature since it does not require Author at this time.

That would break backwards compatibility. So there is some discussion here on this.

Another option is to instead strongly suggest that if you want to submit to GooglePlay Podcasts, you must set podcast.AddAuthor(...) or else the feed will not be valid. This would probably be fine if we make it very clear.

Additional Tags

The library as it exists handles the rest of the required tags for GooglePlay at both the Podcast and Item levels.

But, we should enhance the feed and specify the GooglePlay items anyways to make it explicit. The link above has the GooglePlay tags that match the existing iTunes tags that we would follow.

Categories

We need to match up the GooglePlay categories with the iTunes categories.

Option 1: if they all match, no sweat! Use as is. crossing fingers

Option 2: (much more likely scenario) Refactor the AddCategory() to take in an Enum, and then we write out the appropiate tags for each iTunes and GooglePlay.

That would break backwards compatibility.

Option 3: a clumsy approach would be to just add in a bunch of AddGooglePlayX() funcs where X would be the tag, like Category. I'd prefer not to go down that route though.

Most likely will do Option 2, but breaks the existing. So, Version 2.0.0?

Tag Priority

Note that compatibility that GooglePlay does with iTunes tags (iTunes has no such issue).

@eduncan911 eduncan911 self-assigned this May 13, 2017
@eduncan911 eduncan911 changed the title Enhancement: add Google Play podcast tags Add Google Play podcast tags Feb 5, 2020
eduncan911 added a commit that referenced this issue Feb 7, 2020
# This is the 1st commit message:

Go Mod and Vendor

# This is the commit message #2:

asd

# This is the commit message #3:

asd

# This is the commit message #4:

asd

# This is the commit message #5:

asd

# This is the commit message #6:

asd

# This is the commit message #7:

asd

# This is the commit message #8:

asd

# This is the commit message #9:

asd
@shelomito12
Copy link

Basic itunes:email tag is currently missing in v2.4.0 when the XML is generated. In order to register my RSS feed with Apple Podcasts or Spotify, they require a valid email to get an authorization link. We can't use PodSync at the moment. Please see mxpv/podsync#171

@eduncan911
Copy link
Owner Author

eduncan911 commented Oct 28, 2020

@jzvi12 actually, it's already in the package.

p.IOwner = &Author{
	Name:  name,
	Email: email,
}

They would need to set them in that podsync codebase.

@eduncan911
Copy link
Owner Author

eduncan911 commented Oct 28, 2020

@jzvi12 I'm posting a solution in mxpv/podsync#171 for them to add to their codebase.

EDIT: Posted the information for them to make it work: mxpv/podsync#171 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants