Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an error message typo #6

Merged
merged 1 commit into from
May 12, 2017
Merged

Fix an error message typo #6

merged 1 commit into from
May 12, 2017

Conversation

guywithnose
Copy link
Contributor

No description provided.

@eduncan911
Copy link
Owner

I am not sure why Coveralls is failing in the Travis build. It works for my other PR #5 that I have open.

I've opened a ticket with Coveralls to see what's up.

As for the actual PR, LGTM! I'll squash and push it up as soon as I hear from Coveralls.


OT: What do you think about that podcast.New() API method? Simple? Overly complex? Should/shouldn't use nils? etc?

I previously had open a discussion issue #2 where I was thinking of refactoring it. But, it would break existing compatibility.

Feel free to comment in #2 about more details. I am open to feedback, especially since I am working on #5 ATM which will be a Version 2.x milestone.

@eduncan911
Copy link
Owner

Still not sure why coveralls still fails. Perhaps it's because your repo doesn't have access to my coveralls account?

Regardless, they never responded to my open support request.

I'll go ahead and merge this since other tests shows 100% coverage anyways.

@eduncan911 eduncan911 merged commit 01d5656 into eduncan911:master May 12, 2017
eduncan911 added a commit that referenced this pull request Feb 7, 2020
# This is the 1st commit message:

Go Mod and Vendor

# This is the commit message #2:

asd

# This is the commit message #3:

asd

# This is the commit message #4:

asd

# This is the commit message #5:

asd

# This is the commit message #6:

asd

# This is the commit message #7:

asd

# This is the commit message #8:

asd

# This is the commit message #9:

asd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants