Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

heading and cards refactoring #227

Merged
merged 56 commits into from
Aug 20, 2022
Merged

heading and cards refactoring #227

merged 56 commits into from
Aug 20, 2022

Conversation

ichim-david
Copy link
Member

No description provided.

tarantilis and others added 30 commits May 19, 2022 09:22
# Conflicts:
#	theme/themes/eea/views/card.variables
ichim-david and others added 25 commits August 16, 2022 18:45
- introduced 2 extra values to account for other values used
  in the design system
- use 1.2 for all headings as discussed in design meetings
- in numbers only due to calculations otherwise they are rendered really
  small
…urus

- in the typographic guide it makes sense to actually implement the values that are
  described and the best way to see how they look is to use the same font
- Modified letter spacing to use 1%, 1.5% positive and negative values after looking at figma implementation
  and docusaurus documentation
- Added information about the line height used by headers which is different from the body text
- Modified font sizes with the latest values
- Added font size also in px so easier understanding of values as opposed to rem values
- Modified fluid font sizes now that we no longer have values higher than 2.75rem
- Modified font family stack of docusaurus to include Arial fallback as described in the typography
  section
- Use tiny class for 12px small text in line with our tiny class from Semantic
- bringing the color from the design system also in the docusaurus site
…rroring the design system styles

- added letter spacing to the text examples from typography section
…cusaurus

- tweaked lineheight-0 since the headers now use 1.2 instead of 1.25
- tiny and discreet class have some letterspacing applied as documented in docusaurus
…n easily choose another heading color

- also introduced contentAreaColor since this color will probably only be set for the new eea website
…d inherit color

- this way we keep the same sizes as in the figma file even though the hero uses an h2 tag
- this way if we place a header in a content box and it has a color set the
  headers will also switch to that color
@github-actions
Copy link

👋 @ichim-david

To generate the Storybook and Docusaurus websites, write comment with:

@eea-jenkins build all

To generate only Storybook write comment with:

@eea-jenkins build storybook

To generate only Docusaurus write comment with:

@eea-jenkins build docusaurus

@github-pages github-pages bot temporarily deployed to github-pages August 20, 2022 18:36 Inactive
@ichim-david ichim-david merged commit 334fbda into master Aug 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants