fix: add patch method for update (egg#1793) #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dead-horse
reviewed
Jan 8, 2018
| @@ -119,7 +123,8 @@ class Router extends KoaRouter { | |||
| * GET | /posts/:id | post | app.controller.posts.show | |||
| * GET | /posts/:id/edit | edit_post | app.controller.posts.edit | |||
| * POST | /posts | posts | app.controller.posts.create | |||
| * PUT | /posts/:id | post | app.controller.posts.update | |||
| * PATCH | /posts/:id | post | app.controller.posts.update | |||
There was a problem hiding this comment.
patch => app.controller.posts.patch 吧
dead-horse
reviewed
Jan 8, 2018
lib/utils/router.js
Outdated
| @@ -119,7 +123,8 @@ class Router extends KoaRouter { | |||
| * GET | /posts/:id | post | app.controller.posts.show | |||
| * GET | /posts/:id/edit | edit_post | app.controller.posts.edit | |||
| * POST | /posts | posts | app.controller.posts.create | |||
| * PUT | /posts/:id | post | app.controller.posts.update | |||
| * PATCH | /posts/:id | post | app.controller.posts.update | |||
| * PUT | /posts | posts | app.controller.posts.updateAll | |||
Codecov Report
@@ Coverage Diff @@
## master #150 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 17 17
Lines 884 885 +1
=====================================
+ Hits 884 885 +1
Continue to review full report at Codecov.
|
dead-horse
reviewed
Jan 9, 2018
lib/utils/router.js
Outdated
| @@ -119,7 +123,8 @@ class Router extends KoaRouter { | |||
| * GET | /posts/:id | post | app.controller.posts.show | |||
| * GET | /posts/:id/edit | edit_post | app.controller.posts.edit | |||
| * POST | /posts | posts | app.controller.posts.create | |||
| * PUT | /posts/:id | post | app.controller.posts.update | |||
| * PATCH | /posts/:id | post | app.controller.posts.patch | |||
| * PUT | /posts | posts | app.controller.posts.update | |||
dead-horse
reviewed
Jan 9, 2018
| exports.update = function* () { | ||
| this.body = 'update - ' + this.params.id; | ||
| this.body = 'update'; |
|
尴尬， 我搞错 put 含义了， 已改正！ |
4 tasks
atian25
changed the title
mosaic101
changed the title
dead-horse
reviewed
Jan 17, 2018
lib/utils/router.js
Outdated
| @@ -38,7 +38,7 @@ const REST_MAP = { | |||
| member: true, | |||
| namePrefix: '', | |||
| suffix: ':id', | |||
| method: 'PUT', | |||
| method: 'PATCH', | |||
mosaic101
changed the title
dead-horse
approved these changes
Jan 18, 2018
|
4.4.0 |
hyj1991
pushed a commit
to hyj1991/egg-core
that referenced
this pull request
Sep 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm testpassesAffected core subsystem(s)
Description of change
fix:#1793