-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add patch method for update (egg#1793) #150
Merged
Merged
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
e0b082a
add patch method to follow restful
mosaic101 78926ab
add patch method
mosaic101 7bced4b
add patch method
mosaic101 5bb913d
Merge remote-tracking branch 'upstream/master'
mosaic101 90dc6ed
deprecate PUT
mosaic101 80c0047
tmp
mosaic101 14a6ca5
tmp
mosaic101 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -38,7 +38,7 @@ const REST_MAP = { | |
member: true, | ||
namePrefix: '', | ||
suffix: ':id', | ||
method: 'PUT', | ||
method: 'PATCH', | ||
}, | ||
destroy: { | ||
member: true, | ||
|
@@ -121,7 +121,7 @@ class Router extends KoaRouter { | |
* GET | /posts/:id | post | app.controller.posts.show | ||
* GET | /posts/:id/edit | edit_post | app.controller.posts.edit | ||
* POST | /posts | posts | app.controller.posts.create | ||
* PUT | /posts/:id | post | app.controller.posts.update | ||
* PATCH | /posts/:id | post | app.controller.posts.update | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. patch => app.controller.posts.patch 吧 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 好的 |
||
* DELETE | /posts/:id | post | app.controller.posts.destroy | ||
* | ||
* app.router.url can generate url based on arguments | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PUT还是要保留的,文档中改成 PATCH