added active inactive validation

[Bhavya-egov]

No description provided.

[coderabbitai]

Walkthrough

Walkthrough

The changes to UploadData.js enhance the convertIntoSchema function, restructure async/await calls within useEffect hooks, and refine data processing logic for Excel sheet parsing and filtering. These updates aim to improve code efficiency and data handling accuracy.

Changes

File Path	Change Summary
.../campaign-manager/src/components/UploadData.js	Modified convertIntoSchema function, restructured async/await calls within useEffect hooks, and adjusted data processing logic for Excel sheet parsing and filtering.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant UploadDataComponent
    participant ExcelParser
    participant SchemaConverter

    User->>UploadDataComponent: Upload Excel File
    UploadDataComponent->>ExcelParser: Parse Excel File
    ExcelParser-->>UploadDataComponent: Parsed Data
    UploadDataComponent->>SchemaConverter: Convert Data into Schema
    SchemaConverter-->>UploadDataComponent: Schema-Formatted Data
    UploadDataComponent-->>User: Display Processed Data

Loading

Poem

In the realm of code so bright,
UploadData takes new flight.
Async calls now smooth and clear,
Excel parsing without fear.
Schema forms with graceful might,
Data flows, a pure delight.
🎉🐇✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

Outside diff range and nitpick comments (7)

micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/components/UploadData.js (7)

Line range hint 91-91: Avoid using the delete operator as it can impact performance.

Consider setting the property to undefined instead of deleting it to avoid potential performance issues:

- delete newSchema.unique;
+ newSchema.unique = undefined;

---

Line range hint 129-129: Avoid using the delete operator as it can impact performance.

Consider setting the property to undefined instead of deleting it to avoid potential performance issues:

- delete data.campaignType;
+ data.campaignType = undefined;

---

Line range hint 141-141: Ensure safe usage of optional chaining to prevent runtime errors.

Check if the optional chaining operation might result in undefined which could lead to a TypeError. Consider adding null checks or default values.

---

Line range hint 293-300: The else clause is unnecessary and can be omitted for cleaner code.

You can remove the else clause to simplify the control flow since the previous branches use return statements:

- } else {
-   if (SheetNames !== t("HCM_ADMIN_CONSOLE_USER_LIST")) {
-     const errorMessage = t("HCM_INVALID_USER_SHEET");
-     setErrorsType((prevErrors) => ({
-       ...prevErrors,
-       [type]: errorMessage,
-     }));
-     setIsError(true);
-     return;
-   }
- }
+ if (SheetNames !== t("HCM_ADMIN_CONSOLE_USER_LIST")) {
+   const errorMessage = t("HCM_INVALID_USER_SHEET");
+   setErrorsType((prevErrors) => ({
+     ...prevErrors,
+     [type]: errorMessage,
+   }));
+   setIsError(true);
+   return;
+ }

---

Line range hint 315-315: Use strict equality checks to avoid potential bugs due to type coercion.

Replace == with === and != with !== to ensure strict type comparison:

- if (filteredData.length == 0) {
+ if (filteredData.length === 0) {
- if (targetValue <= 0 || targetValue >= 100000000) {
+ if (targetValue <= 0 || targetValue >= 100000000) {
- if (jsonData.length == 0) {
+ if (jsonData.length === 0) {
- if (fileData && fileData?.[0]?.url) {
+ if (fileData && fileData?.[0]?.url) {
- if (!result?.GeneratedResource?.[0]?.fileStoreid || result?.GeneratedResource?.length == 0) {
+ if (!result?.GeneratedResource?.[0]?.fileStoreid || result?.GeneratedResource?.length === 0) {

Also applies to: 420-420, 540-540, 546-546, 816-816

---

Line range hint 906-906: Avoid using array indices as keys in React components.

Using indices as keys can lead to performance issues and bugs in component state management. Use unique identifiers instead:

- {errorsType[type].split(",").map((error, index) => (
+ {errorsType[type].split(",").map((error) => (
- {info?.descriptions.map((desc, i) => (
+ {info?.descriptions.map((desc) => (

Also applies to: 925-925

---

Line range hint 940-988: JSX elements without children should be self-closing to improve readability.

Convert JSX elements without children to self-closing tags:

- <React.Fragment key={index}>
+ <React.Fragment key={index} />
- <React.Fragment key={i}>
+ <React.Fragment key={i} />

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 5974eb3 and 8a64271.

Files selected for processing (1)

• micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/components/UploadData.js (6 hunks)

Additional context used

Path-based instructions (1)

micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/components/UploadData.js (1)

Pattern **/*.js: check

Biome

micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/components/UploadData.js

[error] 91-91: Avoid the delete operator which can impact performance. (lint/performance/noDelete)

Unsafe fix: Use an undefined assignment instead.

---

[error] 129-129: Avoid the delete operator which can impact performance. (lint/performance/noDelete)

Unsafe fix: Use an undefined assignment instead.

---

[error] 141-141: Unsafe usage of optional chaining. (lint/correctness/noUnsafeOptionalChaining)

If it short-circuits with 'undefined' the evaluation will throw TypeError here:

---

[error] 293-300: This else clause can be omitted because previous branches break early. (lint/style/noUselessElse)

Unsafe fix: Omit the else clause.

---

[error] 315-315: Use === instead of ==.
== is only allowed when comparing against null (lint/suspicious/noDoubleEquals)

== is only allowed when comparing against null

Using == may be unsafe if you are relying on type coercion
Unsafe fix: Use ===

---

[error] 420-420: Use === instead of ==.
== is only allowed when comparing against null (lint/suspicious/noDoubleEquals)

== is only allowed when comparing against null

Using == may be unsafe if you are relying on type coercion
Unsafe fix: Use ===

---

[error] 420-420: Use !== instead of !=.
!= is only allowed when comparing against null (lint/suspicious/noDoubleEquals)

!= is only allowed when comparing against null

Using != may be unsafe if you are relying on type coercion
Unsafe fix: Use !==

---

[error] 471-480: This var should be declared at the root of the enclosing function. (lint/correctness/noInnerDeclarations)

The var is accessible in the whole body of the enclosing function.
To avoid confusion, it should be declared at the root of the enclosing function.

---

[error] 540-540: Use === instead of ==.
== is only allowed when comparing against null (lint/suspicious/noDoubleEquals)

== is only allowed when comparing against null

Using == may be unsafe if you are relying on type coercion
Unsafe fix: Use ===

---

[error] 546-546: Use === instead of ==.
== is only allowed when comparing against null (lint/suspicious/noDoubleEquals)

== is only allowed when comparing against null

Using == may be unsafe if you are relying on type coercion
Unsafe fix: Use ===

---

[error] 613-613: Change to an optional chain. (lint/complexity/useOptionalChain)

Unsafe fix: Change to an optional chain.

---

[error] 650-685: This else clause can be omitted because previous branches break early. (lint/style/noUselessElse)

Unsafe fix: Omit the else clause.

---

[error] 656-684: This else clause can be omitted because previous branches break early. (lint/style/noUselessElse)

Unsafe fix: Omit the else clause.

---

[error] 693-721: This else clause can be omitted because previous branches break early. (lint/style/noUselessElse)

Unsafe fix: Omit the else clause.

---

[error] 816-816: Use === instead of ==.
== is only allowed when comparing against null (lint/suspicious/noDoubleEquals)

== is only allowed when comparing against null

Using == may be unsafe if you are relying on type coercion
Unsafe fix: Use ===

---

[error] 833-833: Change to an optional chain. (lint/complexity/useOptionalChain)

Unsafe fix: Change to an optional chain.

---

[error] 940-988: JSX elements without children should be marked as self-closing. In JSX, it is valid for any element to be self-closing. (lint/style/useSelfClosingElements)

Unsafe fix: Use a SelfClosingElement instead

---

[error] 980-980: The comma operator is disallowed. (lint/style/noCommaOperator)

Its use is often confusing and obscures side effects.

---

[error] 906-906: Avoid using the index of an array as key property in an element. (lint/suspicious/noArrayIndexKey)

This is the source of the key value.

The order of the items may change, and this also affects performances and component state.
Check the React documentation.

---

[error] 925-925: Avoid using the index of an array as key property in an element. (lint/suspicious/noArrayIndexKey)

This is the source of the key value.

The order of the items may change, and this also affects performances and component state.
Check the React documentation.

[coderabbitai]

Declare variables at the root of the enclosing function to avoid confusion.

Move the declaration of jsonData to the top of the function to improve readability and maintainability:

+ var jsonData;
  var jsonData = sheetData.map((row, index) => {
    const rowData = {};
    if (Object.keys(row).length > 0) {
      Object.keys(row).forEach((key) => {
        rowData[key] = row[key] === undefined || row[key] === "" ? "" : row[key];
      });
      rowData["!row#number!"] = index + 1; // Adding row number
      return rowData;
    }
  });

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

	var jsonData = sheetData.map((row, index) => {
	const rowData = {};
	if (Object.keys(row).length > 0) {
	Object.keys(row).forEach((key) => {
	rowData[key] = row[key] === undefined || row[key] === "" ? "" : row[key];
	});
	rowData["!row#number!"] = index + 1; // Adding row number
	return rowData;
	}
	});
	var jsonData;
	jsonData = sheetData.map((row, index) => {
	const rowData = {};
	if (Object.keys(row).length > 0) {
	Object.keys(row).forEach((key) => {
	rowData[key] = row[key] === undefined || row[key] === "" ? "" : row[key];
	});
	rowData["!row#number!"] = index + 1; // Adding row number
	return rowData;
	}
	});

Tools

Biome

[error] 471-480: This var should be declared at the root of the enclosing function. (lint/correctness/noInnerDeclarations)

The var is accessible in the whole body of the enclosing function.
To avoid confusion, it should be declared at the root of the enclosing function.