Added roboto font

[ashish-egov]

No description provided.

[coderabbitai]

Walkthrough

Walkthrough

The recent updates primarily focus on transitioning configurations from a QA to a development environment. This includes changing host URLs, database configurations, and Kafka broker settings. Additionally, new utility functions were added to handle font updates in Excel sheets, and some old, commented-out code was cleaned up.

Changes

File Path	Change Summary
.../config/index.ts	Updated host URLs and configurations to point to the development environment instead of QA.
.../utils/campaignUtils.ts	Added updateFontNameToRoboto function calls, added logging, and removed old commented-out code.
.../utils/excelUtils.ts	Introduced updateFontNameToRoboto function and updated export statements.
.../utils/genericUtils.ts	Integrated updateFontNameToRoboto function in createReadMeSheet.

Poem

In the land of code, we shift and sway,
From QA to dev, we find our way.
URLs updated, Kafka in place,
Roboto fonts now set the pace.
With cleaner scripts, our path is clear,
To build and launch without a fear. 🌟

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 2

Outside diff range and nitpick comments (3)

utilities/project-factory/src/server/utils/campaignUtils.ts (3)

Line range hint 401-401: Move variable declarations to the top of the function to enhance readability and maintain standard JavaScript practices.

+ var columns;
function processErrorData(request, createAndSearchConfig, workbook, sheetName, localizationMap) {
-    var columns;
    ...
}

---

Line range hint 610-613: Remove unnecessary else clause to simplify control flow and enhance code readability.

if (condition) {
    // code
- } else {
-    return;
- }
}

---

Line range hint 842-852: Replace the use of the delete operator with setting properties to undefined for better performance in JavaScript engines.

- delete requestBody.CampaignDetails.campaignDetails;
+ requestBody.CampaignDetails.campaignDetails = undefined;

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 81c68e9 and 74c5648.

Files selected for processing (4)

• utilities/project-factory/src/server/config/index.ts (3 hunks)
• utilities/project-factory/src/server/utils/campaignUtils.ts (7 hunks)
• utilities/project-factory/src/server/utils/excelUtils.ts (4 hunks)
• utilities/project-factory/src/server/utils/genericUtils.ts (3 hunks)

Additional context used

Biome

utilities/project-factory/src/server/utils/genericUtils.ts

[error] 46-51: This else clause can be omitted because previous branches break early. (lint/style/noUselessElse)

Unsafe fix: Omit the else clause.

---

[error] 338-338: Unsafe usage of optional chaining. (lint/correctness/noUnsafeOptionalChaining)

If it short-circuits with 'undefined' the evaluation will throw TypeError here:

---

[error] 531-531: Unsafe usage of optional chaining. (lint/correctness/noUnsafeOptionalChaining)

If it short-circuits with 'undefined' the evaluation will throw TypeError here:

---

[error] 555-558: This else clause can be omitted because previous branches break early. (lint/style/noUselessElse)

Unsafe fix: Omit the else clause.

---

[error] 677-677: The comma operator is disallowed. (lint/style/noCommaOperator)

Its use is often confusing and obscures side effects.

---

[error] 760-760: This var should be declared at the root of the enclosing function. (lint/correctness/noInnerDeclarations)

The var is accessible in the whole body of the enclosing function.
To avoid confusion, it should be declared at the root of the enclosing function.

---

[error] 761-761: This var should be declared at the root of the enclosing function. (lint/correctness/noInnerDeclarations)

The var is accessible in the whole body of the enclosing function.
To avoid confusion, it should be declared at the root of the enclosing function.

---

[error] 763-763: Do not access Object.prototype method 'hasOwnProperty' from target object. (lint/suspicious/noPrototypeBuiltins)

It's recommended using Object.hasOwn() instead of using Object.hasOwnProperty().
See MDN web docs for more details.

---

[error] 779-779: Unsafe usage of optional chaining. (lint/correctness/noUnsafeOptionalChaining)

If it short-circuits with 'undefined' the evaluation will throw TypeError here:

---

[error] 800-803: This else clause can be omitted because previous branches break early. (lint/style/noUselessElse)

Unsafe fix: Omit the else clause.

---

[error] 807-807: Do not access Object.prototype method 'hasOwnProperty' from target object. (lint/suspicious/noPrototypeBuiltins)

It's recommended using Object.hasOwn() instead of using Object.hasOwnProperty().
See MDN web docs for more details.

---

[error] 148-148: Don't use 'Number' as a type. (lint/complexity/noBannedTypes)

Use lowercase primitives for consistency.
Safe fix: Use 'number' instead

utilities/project-factory/src/server/utils/campaignUtils.ts

[error] 401-401: This var should be declared at the root of the enclosing function. (lint/correctness/noInnerDeclarations)

The var is accessible in the whole body of the enclosing function.
To avoid confusion, it should be declared at the root of the enclosing function.

---

[error] 437-437: Unsafe usage of optional chaining. (lint/correctness/noUnsafeOptionalChaining)

If it short-circuits with 'undefined' the evaluation will throw TypeError here:

---

[error] 484-484: Unsafe usage of optional chaining. (lint/correctness/noUnsafeOptionalChaining)

If it short-circuits with 'undefined' the evaluation will throw TypeError here:

---

[error] 526-526: Avoid the delete operator which can impact performance. (lint/performance/noDelete)

Unsafe fix: Use an undefined assignment instead.

---

[error] 555-555: Avoid the delete operator which can impact performance. (lint/performance/noDelete)

Unsafe fix: Use an undefined assignment instead.

---

[error] 557-557: Avoid the delete operator which can impact performance. (lint/performance/noDelete)

Unsafe fix: Use an undefined assignment instead.

---

[error] 593-593: Avoid the delete operator which can impact performance. (lint/performance/noDelete)

Unsafe fix: Use an undefined assignment instead.

---

[error] 595-595: Avoid the delete operator which can impact performance. (lint/performance/noDelete)

Unsafe fix: Use an undefined assignment instead.

---

[error] 596-596: Avoid the delete operator which can impact performance. (lint/performance/noDelete)

Unsafe fix: Use an undefined assignment instead.

---

[error] 610-613: This var should be declared at the root of the enclosing function. (lint/correctness/noInnerDeclarations)

The var is accessible in the whole body of the enclosing function.
To avoid confusion, it should be declared at the root of the enclosing function.

---

[error] 627-627: This var should be declared at the root of the enclosing function. (lint/correctness/noInnerDeclarations)

The var is accessible in the whole body of the enclosing function.
To avoid confusion, it should be declared at the root of the enclosing function.

---

[error] 727-729: This else clause can be omitted because previous branches break early. (lint/style/noUselessElse)

Unsafe fix: Omit the else clause.

---

[error] 842-842: Avoid the delete operator which can impact performance. (lint/performance/noDelete)

Unsafe fix: Use an undefined assignment instead.

---

[error] 849-849: Avoid the delete operator which can impact performance. (lint/performance/noDelete)

Unsafe fix: Use an undefined assignment instead.

---

[error] 850-850: Avoid the delete operator which can impact performance. (lint/performance/noDelete)

Unsafe fix: Use an undefined assignment instead.

---

[error] 851-851: Avoid the delete operator which can impact performance. (lint/performance/noDelete)

Unsafe fix: Use an undefined assignment instead.

---

[error] 852-852: Avoid the delete operator which can impact performance. (lint/performance/noDelete)

Unsafe fix: Use an undefined assignment instead.

---

[error] 1046-1046: Unsafe usage of optional chaining. (lint/correctness/noUnsafeOptionalChaining)

If it short-circuits with 'undefined' the evaluation will throw TypeError here:

---

[error] 1064-1067: This var should be declared at the root of the enclosing function. (lint/correctness/noInnerDeclarations)

The var is accessible in the whole body of the enclosing function.
To avoid confusion, it should be declared at the root of the enclosing function.

---

[error] 1068-1068: This var should be declared at the root of the enclosing function. (lint/correctness/noInnerDeclarations)

The var is accessible in the whole body of the enclosing function.
To avoid confusion, it should be declared at the root of the enclosing function.

Additional comments not posted (10)

utilities/project-factory/src/server/utils/excelUtils.ts (3)

57-70: The function updateFontNameToRoboto effectively updates the font of all cells in a worksheet to 'Roboto'. This is a straightforward implementation that preserves existing font properties while updating the font name. Good use of spreading existing properties to avoid overwriting other font attributes.

---

176-176: The call to updateFontNameToRoboto within addDataToSheet ensures that the Roboto font is applied consistently across sheets created or modified by this function. This aligns with the PR's objective to standardize the font across various utilities.

---

230-230: The export statement has been updated to include updateFontNameToRoboto, making it available for import in other modules. This change supports the reusability of the new function across different parts of the application.

utilities/project-factory/src/server/config/index.ts (3)

6-6: The HOST constant has been updated to point to the development environment URL. This change is crucial for ensuring that the application points to the correct environment during development. Make sure to revert this change or manage it via environment variables for production deployments.

---

51-52: The database configuration has been updated to use more standard defaults for the development environment (DB_NAME and DB_PASSWORD). This change should simplify the configuration for new developers and align with common practices.

---

76-89: The Kafka broker host and various service endpoints have been updated to reflect the new development environment. This comprehensive update is essential for ensuring that all external service calls are directed to the correct URLs in the development context.

utilities/project-factory/src/server/utils/genericUtils.ts (3)

17-17: The import statement for updateFontNameToRoboto from excelUtils is correctly added to utilize this function within genericUtils. This change supports the integration of the new font update functionality across different utility functions.

---

489-490: The updateFontNameToRoboto function is appropriately called within createReadMeSheet to apply the Roboto font to the newly created ReadMe sheet. This ensures consistency in font usage across different sheets generated by the application.

---

561-561: The function changeFirstRowColumnColour is correctly defined to change the color of the first row's column in a sheet. This utility function can be used to highlight headers or important columns, improving the readability of the data.

utilities/project-factory/src/server/utils/campaignUtils.ts (1)

19-19: Ensure the import of updateFontNameToRoboto is utilized correctly throughout the file.

[coderabbitai]

The call to updateFontNameToRoboto should be followed by error handling to ensure robustness.

- updateFontNameToRoboto(worksheet)
+ try {
+     updateFontNameToRoboto(worksheet);
+ } catch (error) {
+     logger.error('Failed to update font name to Roboto:', error);
+ }

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

	updateFontNameToRoboto(worksheet)
	try {
	updateFontNameToRoboto(worksheet);
	} catch (error) {
	logger.error('Failed to update font name to Roboto:', error);
	}

[coderabbitai]

Similar to the previous comment, add error handling around the updateFontNameToRoboto function call.

- updateFontNameToRoboto(desiredSheet)
+ try {
+     updateFontNameToRoboto(desiredSheet);
+ } catch (error) {
+     logger.error('Failed to update font name to Roboto in desiredSheet:', error);
+ }