-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: use IRTConfig.cmake
vars
#546
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c-dilks
changed the title
build: respect irt/#31
build: respect https://github.com/eic/irt/pull/31
Mar 16, 2023
c-dilks
changed the title
build: respect https://github.com/eic/irt/pull/31
build: respect IRT build refactoring
Mar 16, 2023
7 tasks
veprbl
reviewed
Mar 16, 2023
c-dilks
force-pushed
the
debug-irt-build
branch
from
March 17, 2023 22:58
b95f4ed
to
38f7b8c
Compare
c-dilks
changed the title
build: respect IRT build refactoring
build: use Mar 17, 2023
IRT_LIBRARY_DIR
and IRT_INCLUDE_DIR
Ready when |
c-dilks
force-pushed
the
debug-irt-build
branch
from
March 21, 2023 17:40
38f7b8c
to
3b79560
Compare
c-dilks
changed the title
build: use
build: use Mar 21, 2023
IRT_LIBRARY_DIR
and IRT_INCLUDE_DIR
IRTConfig.cmake
vars and include headers in ROOT_INCLUDE_PATH
IRT |
c-dilks
force-pushed
the
debug-irt-build
branch
from
March 24, 2023 23:42
34ca32c
to
ce47448
Compare
v1.0.5 out but cling errors persist. |
c-dilks
force-pushed
the
debug-irt-build
branch
from
March 25, 2023 15:37
e89b153
to
17192a8
Compare
c-dilks
changed the title
build: use
build: use Mar 25, 2023
IRTConfig.cmake
vars and include headers in ROOT_INCLUDE_PATH
IRTConfig.cmake
vars
c-dilks
force-pushed
the
debug-irt-build
branch
from
March 28, 2023 02:31
b0cc003
to
c5deb24
Compare
wdconinc
approved these changes
Mar 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce?
Updates for compatibility with eic/irt#31
What kind of change does this PR introduce?
IRT
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
No
Does this PR change default behavior?
No