Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: use IRTConfig.cmake vars #546

Merged
merged 4 commits into from
Mar 28, 2023
Merged

build: use IRTConfig.cmake vars #546

merged 4 commits into from
Mar 28, 2023

Conversation

c-dilks
Copy link
Member

@c-dilks c-dilks commented Mar 16, 2023

Briefly, what does this PR introduce?

Updates for compatibility with eic/irt#31

What kind of change does this PR introduce?

  • Bug fix (issue #__)
  • New feature (issue #__)
  • Documentation update
  • Other: build refactoring in IRT

Please check if this PR fulfills the following:

  • Tests for the changes have been added
  • Documentation has been added / updated
  • Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

No

Does this PR change default behavior?

No

@c-dilks c-dilks changed the title build: respect irt/#31 build: respect https://github.com/eic/irt/pull/31 Mar 16, 2023
@c-dilks c-dilks changed the title build: respect https://github.com/eic/irt/pull/31 build: respect IRT build refactoring Mar 16, 2023
@c-dilks c-dilks changed the title build: respect IRT build refactoring build: use IRT_LIBRARY_DIR and IRT_INCLUDE_DIR Mar 17, 2023
@c-dilks
Copy link
Member Author

c-dilks commented Mar 17, 2023

Ready when irt version v1.0.5 is in the image.

@c-dilks c-dilks changed the title build: use IRT_LIBRARY_DIR and IRT_INCLUDE_DIR build: use IRTConfig.cmake vars and include headers in ROOT_INCLUDE_PATH Mar 21, 2023
@c-dilks
Copy link
Member Author

c-dilks commented Mar 24, 2023

IRT v1.0.5 rolled out, but not yet to CVMFS

@c-dilks
Copy link
Member Author

c-dilks commented Mar 25, 2023

v1.0.5 out but cling errors persist.

@c-dilks c-dilks requested a review from DraTeots March 25, 2023 17:00
@c-dilks c-dilks marked this pull request as ready for review March 25, 2023 17:00
@c-dilks c-dilks changed the title build: use IRTConfig.cmake vars and include headers in ROOT_INCLUDE_PATH build: use IRTConfig.cmake vars Mar 25, 2023
@c-dilks c-dilks enabled auto-merge (squash) March 25, 2023 21:41
@c-dilks c-dilks merged commit f7c9762 into main Mar 28, 2023
@c-dilks c-dilks deleted the debug-irt-build branch March 28, 2023 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants