-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: use GNUInstallDirs
and improve packaging
#31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
veprbl
reviewed
Mar 16, 2023
Co-authored-by: Dmitry Kalinkin <dmitry.kalinkin@gmail.com>
Tested IRT PID in EICrecon, still works fine. |
veprbl
reviewed
Mar 18, 2023
Co-authored-by: Dmitry Kalinkin <dmitry.kalinkin@gmail.com>
veprbl
approved these changes
Mar 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce?
GNUInstallDirs
to set the installation tree, instead of doing it "by hand"cmake
files inlib/cmake/IRT
instead of inlib/IRT
IRT_LIBRARY_DIR
andIRT_INCLUDE_DIR
IRTConfig.cmake
vars EICrecon#546Installation tree before this PR:
After this PR:
What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
Yes, see above PR on EICrecon. This also might break Juggler's usage (on a dev branch, not
main
).This also might impact @alexander-kiselev's usage
Does this PR change default behavior?
No, but hopefully it solves our various build/linking/
cling
/etc. problems in EICrecon...