Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a Contract Fist approach to define Actors #302

Merged
merged 53 commits into from
Jun 11, 2024
Merged

Conversation

sleipnir
Copy link
Member

Warning: This PR introduces breaking changes.

Once this PR is finalized, Spawn will start using a completely contract-first approach in defining its Actors as users will have to create gRPC services that will be mapped 1:1 with the Actors.

This will allow us to:

  1. The proxy becomes aware of the user types. This is good because it expands our range of possibilities in implementing new features.
  2. Users will have a simpler way to know which Actions and Actors exist. Just look at or share .proto file between different projects and everyone will be able to know what can be invoked and how.
  3. We will be able to transparently expose Actor Actions externally via gRPC and HTTP (the latter via HTTP transcoding).

What blocks this PR from being merged:

  • Finalize the gRPC dispatcher.
  • More tests.
  • This PR in the elixir-grpc repository and the subsequent new version published in the hex.pm repository.

@sleipnir sleipnir changed the title Feat/embedded grpc Use a Contract Fist approach to define Actors Feb 23, 2024
@sleipnir
Copy link
Member Author

When completes this closes #32

@sleipnir sleipnir mentioned this pull request Mar 13, 2024
@sleipnir sleipnir marked this pull request as ready for review April 29, 2024 13:40
@sleipnir sleipnir marked this pull request as draft June 5, 2024 18:02
@sleipnir sleipnir marked this pull request as ready for review June 11, 2024 18:23
@sleipnir sleipnir merged commit d8f58d1 into main Jun 11, 2024
1 check passed
@sleipnir sleipnir mentioned this pull request Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants