-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/http transcoding (Continuation) #351
Merged
polvalente
merged 75 commits into
elixir-grpc:master
from
sleipnir:feat/http-transcoding
Mar 25, 2024
Merged
Feat/http transcoding (Continuation) #351
polvalente
merged 75 commits into
elixir-grpc:master
from
sleipnir:feat/http-transcoding
Mar 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Routes are fetched from server and compiled into a dispatch conf. Instead of finding a matching server in the handler the path is matched and the handler is called with the correct server.
ping @polvalente @drowzy |
polvalente
reviewed
Mar 25, 2024
polvalente
reviewed
Mar 25, 2024
polvalente
reviewed
Mar 25, 2024
polvalente
reviewed
Mar 25, 2024
polvalente
reviewed
Mar 25, 2024
polvalente
approved these changes
Mar 25, 2024
Thank you @polvalente |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR continues the excellent work started by @drowzy in his PR #273. The merit of this work must be given entirely to @drowzy.
I just made some small fixes and eliminated all the deprecated code from the Protobuf api, as well as merging it with the recent codebase and fixing some tests.
I hope @drowzy doesn't mind that I picked up where he left off. But I accept it if you don't want to continue with this PR here. Again I reiterate that he did an excellent job in his previous PR.
closes #273
Below is the text copied from the original PR (#273):
Support for gRPC transcoding.
This feature is opt-in using the http_transcode option in the server definition:
Request/response mapping can be controlled by adding grpc-gateway annotations to your proto definition:
This PR does not require any changes to user code.
For a full list of features see #273