Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add priv to package #360

Merged

Conversation

fahchen
Copy link
Contributor

@fahchen fahchen commented Apr 8, 2024

When I upgrade gRPC from 0.7.0 to 0.8.0, the gRPC compile fails.
I found that the PR #351 introduces priv/templates/service.ex.eex, but it isn’t added to package.

To Reproduce

  1. cd examples/helloworld

  2. Change grpc source to hex

diff --git a/examples/helloworld/mix.exs b/examples/helloworld/mix.exs
index 497b7b1..7ca52df 100644
--- a/examples/helloworld/mix.exs
+++ b/examples/helloworld/mix.exs
@@ -18,7 +18,7 @@ defmodule Helloworld.Mixfile do
 
   defp deps do
     [
-      {:grpc, path: "../../"},
+      {:grpc, "~> 0.8"},
       {:jason, "~> 1.3.0"},
       {:protobuf, "~> 0.11"},
       {:google_protos, "~> 0.3.0"},
  1. mix deps.get && mix compile
==> grpc
Compiling 1 file (.erl)
Compiling 49 files (.ex)

== Compilation error in file lib/grpc/protoc/generator/service.ex ==
** (File.Error) could not read file "grpc/examples/helloworld/_build/dev/lib/grpc/priv/templates/service.ex.eex": no such file or directory
    (elixir 1.15.7) lib/file.ex:358: File.read!/1
    (eex 1.15.7) lib/eex.ex:259: EEx.compile_file/2
    lib/grpc/protoc/generator/service.ex:9: (module)
could not compile dependency :grpc, "mix compile" failed. Errors may have been logged above. You can recompile this dependency with "mix deps.compile grpc --force", update it with "mix deps.update grpc" or clean it with "mix deps.clean grpc"

@polvalente
Copy link
Contributor

Thanks! I'll release 0.8.1 shortly.

@polvalente polvalente merged commit 969f9c1 into elixir-grpc:master Apr 8, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants