Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Icon on menu bar appearing when interacting with Dockdoor traffic lights #95

Closed
illavoluntas opened this issue Jul 8, 2024 · 2 comments · Fixed by #98
Closed

Bug: Icon on menu bar appearing when interacting with Dockdoor traffic lights #95

illavoluntas opened this issue Jul 8, 2024 · 2 comments · Fixed by #98

Comments

@illavoluntas
Copy link
Contributor

DockDoor menu bar icon appears when interacting with the traffic light buttons in the dock, even if the setting "Show menu bar icon" is disabled. Issue appeared in 1.0.16.

Screenshot

ScreenRecording.mov
@illavoluntas illavoluntas changed the title Bug: Icon on menu bar appearing when interacting with DockDoor Bug: Icon on menu bar appearing when interacting with Dockdoor traffic lights Jul 8, 2024
@ejbills
Copy link
Owner

ejbills commented Jul 8, 2024

@ShlomoCode this is a byproduct of using application did become active.

@ShlomoCode
Copy link
Contributor

Makes sense... what do you suggest?

@ejbills ejbills closed this as completed Jul 8, 2024
ShlomoCode added a commit to ShlomoCode/DockDoor that referenced this issue Jul 8, 2024
@ShlomoCode
fix: show menu bar icon only on app reopen, not on interact
06ce890 
Moved initialization from `applicationDidBecomeActive` to `applicationShouldHandleReopen` to ensure the menu bar icon is only shown when the app is reopened, and not on other interactions.

closes ejbills#95
see ejbills#76
@ShlomoCode ShlomoCode mentioned this issue Jul 8, 2024
Merged
ShlomoCode added a commit to ShlomoCode/DockDoor that referenced this issue Jul 8, 2024
@ShlomoCode
fix: show menu bar icon only on app reopen, not on interact
7842ebf 
Moved initialization from `applicationDidBecomeActive` to `applicationShouldHandleReopen` to ensure the menu bar icon is only shown when the app is reopened, and not on other interactions.

closes ejbills#95
see ejbills#76
ShlomoCode added a commit to ShlomoCode/DockDoor that referenced this issue Jul 8, 2024
@ShlomoCode
fix: show menu bar icon only on app reopen, not on interact
6b11f2e 
Moved initialization from `applicationDidBecomeActive` to `applicationShouldHandleReopen` to ensure the menu bar icon is only shown when the app is reopened, and not on other interactions.

closes ejbills#95
see ejbills#76
ShlomoCode added a commit to ShlomoCode/DockDoor that referenced this issue Jul 8, 2024
@ShlomoCode
fix: show menu bar icon only on app reopen, not on interact
239b489 
Moved initialization from `applicationDidBecomeActive` to `applicationShouldHandleReopen` to ensure the menu bar icon is only shown when the app is reopened, and not on other interactions.

closes ejbills#95
see ejbills#76
ejbills pushed a commit that referenced this issue Jul 8, 2024
@ShlomoCode
fix: show menu bar icon only on app reopen, not on interact (#98)
7f191a7 
* Reapply "fix: show menu bar icon when app icon is clicked (#90)"

This reverts commit d6c93c3.

* fix: show menu bar icon only on app reopen, not on interact

Moved initialization from `applicationDidBecomeActive` to `applicationShouldHandleReopen` to ensure the menu bar icon is only shown when the app is reopened, and not on other interactions.

closes #95
see #76
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: show menu bar icon only on app reopen, not on interact ShlomoCode/DockDoor
3 participants
@ejbills @ShlomoCode @illavoluntas