fix: show menu bar icon only on app reopen, not on interact #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit d6c93c3.
ShlomoCode
force-pushed
the
fix-menu-bar-icon-visibility
branch
2 times, most recently
from
7842ebf
to
6b11f2e
Compare
Moved initialization from `applicationDidBecomeActive` to `applicationShouldHandleReopen` to ensure the menu bar icon is only shown when the app is reopened, and not on other interactions. closes ejbills#95 see ejbills#76
ShlomoCode
force-pushed
the
fix-menu-bar-icon-visibility
branch
from
6b11f2e
to
239b489
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved initialization from
applicationDidBecomeActive(#90) toapplicationShouldHandleReopento ensure the menu bar icon is only shown when the app is reopened, and not on other interactions.Credit: https://github.com/sindresorhus/System-Color-Picker
closes #95, closes #76