Stricter linting #206
Labels
Milestone
Comments
errordeveloper
added
help wanted
richardcase
added a commit
that referenced
this issue
Oct 10, 2018
Changed the linter from gometalinter to [GolangCI-Lint]( https://github.com/golangci/golangci-lint) as it is faster and the configuration and output are better. Fixed issue highlighted by the new linter. The following linters have been disabled and should be enabled in the future: - gocyclo - lll - gosec This is further to work already carried out in #206 Signed-off-by: Richard Case <richard.case@outlook.com>
errordeveloper
pushed a commit
that referenced
this issue
Oct 11, 2018
Changed the linter from gometalinter to [GolangCI-Lint]( https://github.com/golangci/golangci-lint) as it is faster and the configuration and output are better. Fixed issue highlighted by the new linter. The following linters have been disabled and should be enabled in the future: - gocyclo - lll - gosec This is further to work already carried out in #206 Signed-off-by: Richard Case <richard.case@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As of #193, we have
make lint, but it's in errors-only mode and fairly light. Would be good to review and make it stricter.https://github.com/weaveworks/eksctl/blob/584e85ad3bec1daf73165ed748639fb6f8023a29/.gometalinter.json#L1-L6
The text was updated successfully, but these errors were encountered: