-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed linter and lint fixes #246
Conversation
CI seems unhappy - any ideas? IIRC, we have CGO disabled, so is that why we are getting some CGO weirdness there? |
@errordeveloper - yeah i thought from the message it may bbe because CGO is disabbled. I'm going to have a look this morning. |
We have
|
I've enabled GolangCI, let's see how it works. But for now, I'd just stick to what we have, I don't think gometalinter is that slow. If we could just make GolangCI do its job, it'd be fine by me to use it along the side with current CircleCI setup. |
Here is an idea: let's merge this changes, but without enabling new linter in CircleCI =) |
I like this, now we have some CI redundancy and GolangCI reported before CircleCI jobs finished, because it doesn't run unit tests. |
c36d8a4
to
13500a2
Compare
Changed the linter from gometalinter to [GolangCI-Lint]( https://github.com/golangci/golangci-lint) as it is faster and the configuration and output are better. Fixed issue highlighted by the new linter. The following linters have been disabled and should be enabled in the future: - gocyclo - lll - gosec This is further to work already carried out in #206 Signed-off-by: Richard Case <richard.case@outlook.com>
13500a2
to
24721e2
Compare
24721e2
to
b87b33a
Compare
Nice, thats an even better idea |
Description
Changed the linter from gometalinter to GolangCI-Lint as it is faster
and the configuration and output are better.
Fixed issues highlighted by the new linter. The following
linters have been disabled and should be enabled in the future:
This is further to work already carried out in #206
Checklist
make build
)make test
)humans.txt
file