current-context in ~/.kube/config not cleaned up

[Jeffwan]

What happened?
After I delete the cluster, current-context still have the old context username@cluster-name.us-west-2.eksctl.io which has not been cleaned up.

apiVersion: v1
clusters:
- cluster:
    insecure-skip-tls-verify: true
    server: https://localhost:6443
  name: docker-desktop
contexts:
- context:
    cluster: docker-desktop
    user: docker-desktop
  name: docker-desktop
current-context: username@cluster-name.us-west-2.eksctl.io
kind: Config
preferences: {}
users:
- name: docker-desktop
  user:

if there's only one cluster, result as follow

apiVersion: v1
clusters: []
contexts: []
current-context: username@cluster-name.us-west-2.eksctl.io
kind: Config
preferences: {}
users: []

What you expected to happen?
I expect the cluster context resume to the valid one.

How to reproduce it?
create cluster and delete cluster.

Anything else we need to know?

Versions
Please paste in the output of these commands:

$ eksctl version
[ℹ]  version.Info{BuiltAt:"", GitCommit:"", GitTag:"0.1.19"}
$ uname -a
MacOS
$ kubectl version
Client Version: version.Info{Major:"1", Minor:"13", GitVersion:"v1.13.0", 

Also include your version of heptio-authenticator-aws

Logs
Include the output of the command line when running eksctl. If possible, eksctl should be run with debug logs. For example:
eksctl get clusters -v 4
Make sure you redact any sensitive information before posting.
If the output is long, please consider a Gist.

[errordeveloper]

@Jeffwan thanks for reporting this! I can confirm I've noticed it a few times also. Would you be keen on fixing this?

[Jeffwan]

I've never contributed to eksctl, Let me take a look.

[errordeveloper]

Please do, this should be fairly easy.

…

On Mon, 11 Feb 2019, 6:18 pm Jiaxin Shan ***@***.*** wrote: I've never contributed to eksctl, Let me take a look. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#527 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAPWS5iZfKHW56je9BgIWfbvxSkAD4MJks5vMbP5gaJpZM4axGSG> .

[Jeffwan]

/cc @Jeffwan

[Jeffwan]

@errordeveloper If we have two cluster and delete current using one. Should eksctl set current-context to empty (no current-context) or any context available?

I am thinking auto switch to other context might be user friendly but it bring risk user create/delete resource in other cluster due to mistakes. Using empty context force user choose context after current cluster deletion but it's safe.

What do you think?

[errordeveloper]

We could clear the context whenever it does look like ours (i.e matches <username>@<cluster-name>.<region>.eksctl.io format), and we no longer see the definition of the context itself.