Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup current-context after cluster deletion #537

Merged
merged 1 commit into from
Feb 13, 2019
Merged

Cleanup current-context after cluster deletion #537

merged 1 commit into from
Feb 13, 2019

Conversation

Jeffwan
Copy link
Contributor

@Jeffwan Jeffwan commented Feb 12, 2019 •
edited
Loading

Description

current-context in kubernetes config file was not cleaned up and we always meet problem complaining context not found. This PR cleanup current-context after cluster deletion. User need to select right context later. Documentation and two more test cases added.

Checklist

  • Code compiles correctly (i.e make build)
  • Added tests that cover your change (if possible)
  • All unit tests passing (i.e. make test)
  • All integration tests passing (i.e. make integration-test)
    (manually run integration instead, make integration-test hangs for long time )
  • Added/modified documentation as required (such as the README.md, and examples directory)
  • Added yourself to the humans.txt file

@Jeffwan Jeffwan force-pushed the cleanup_current_context branch from e6a249c to bb552c8 Compare February 12, 2019 21:05
@Jeffwan
Copy link
Contributor Author

Jeffwan commented Feb 12, 2019

Address #527

@Jeffwan
Copy link
Contributor Author

Jeffwan commented Feb 12, 2019

Original one is success but after I rebase humans.txt it's failed. I think it's not related to commit itself.
Could you help rerun test? @errordeveloper

@errordeveloper errordeveloper self-requested a review February 13, 2019 09:55
errordeveloper
errordeveloper approved these changes Feb 13, 2019
View reviewed changes
Copy link
Contributor

@errordeveloper errordeveloper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM! I'll merge, and open another PR to add a few things, and see what's up with the tests.

@errordeveloper
Copy link
Contributor

errordeveloper commented Feb 13, 2019 •
edited
Loading

Looks like test failure was a flake to do with fetching of external dependencies, I've re-triggered the CI job now.

@errordeveloper errordeveloper merged commit d7b3bdc into eksctl-io:master Feb 13, 2019
@errordeveloper errordeveloper mentioned this pull request Feb 13, 2019
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@errordeveloper errordeveloper errordeveloper approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jeffwan @errordeveloper