Changed messages for deleting a cluster #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@richardcase - can you please approve this one? This is @kschumy 1st feature and we want to keep her going with more. |
richardcase
previously approved these changes
Sep 24, 2018
When a user deleted a cluster, the user received a message saying the cluster had been deleted, even if the cluster did not exist. This commit changes the message to inform the user what has been deleted. It also includes more verbose logger messages about what succeeded when debugging. Issue eksctl-io#154, first part
kschumy
force-pushed
the
change-delete
branch
from
97d66a5 to
2e0cc8d
Compare
|
Rebased! |
richardcase
approved these changes
Sep 24, 2018
|
Great work, thanks @kschumy! |
torredil
pushed a commit
to torredil/eksctl
that referenced
this pull request
May 20, 2022
Add liveness probe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When a user deleted a cluster, the user received a message saying the cluster had been deleted, even if the cluster did not exist. This commit changes the message to inform the user what has been deleted. It also includes more verbose logger messages about what succeeded when debugging.
Issue #154, first part
Checklist
make build)make test)humans.txtfile