review how we list and delete clusters #154
Labels
Comments
This was referenced Aug 9, 2018
Merged
|
@errordeveloper -- I would like to work on this feature. Can you assign this to me? |
|
Yes, happy to adding it to you, Kristen. However, I wouldn't advise
starting on this before #132 lands. Have you looked at any of the issues
with 'help wanted' label? Some of those don't have dependencies, and are
relatively easy to tackle.
…On Tue, 28 Aug 2018, 3:28 am Kirsten Schumy, ***@***.***> wrote:
@errordeveloper <https://github.com/errordeveloper> -- I would like to
work on this feature. Can you assign this to me?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#154 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAPWS8qucgupCEcYCfdcCoPzpnDuIHtUks5uVKrngaJpZM4V1fFh>
.
|
kschumy
pushed a commit
to kschumy/eksctl
that referenced
this issue
Sep 22, 2018
When a user deleted a cluster, the user received a message saying the cluster had been deleted, even if the cluster did not exist. This commit changes the message to inform the user what has been deleted. It also includes more verbose logger messages about what succeeded when debugging. Issue eksctl-io#154, first part
5 tasks
kschumy
pushed a commit
to kschumy/eksctl
that referenced
this issue
Sep 24, 2018
When a user deleted a cluster, the user received a message saying the cluster had been deleted, even if the cluster did not exist. This commit changes the message to inform the user what has been deleted. It also includes more verbose logger messages about what succeeded when debugging. Issue eksctl-io#154, first part
kschumy
pushed a commit
to kschumy/eksctl
that referenced
this issue
Sep 27, 2018
When a user deleted a cluster, the user received a message saying the cluster had been deleted, even if the cluster did not exist. This commit changes the message to inform the user what has been deleted. It also includes more verbose logger messages about what succeeded when debugging. Issue eksctl-io#154, first part
torredil
pushed a commit
to torredil/eksctl
that referenced
this issue
May 20, 2022
Fixes: eksctl-io#144 Differentiates container image push between latest and tag and Update READEM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This would be good to do after #132 lands.
Right now we very optimistically let you run
eksctl delete <anything>, and say that we will delete that (even if it doesn't exist). But the output is wrong, in fact we are very strict about what we actually delete. Also, when we actually do delete a cluster, we block on nodegroup, but don't block on control plane (because it would take very long and user shouldn't have to wait most of the time).While with
eksctl get clusters, we currenly list any cluster, even if it wasn't created by us. We should probably list only clusters that we have created via CloudFormation, but offer a flag to list all the clusters also, i.e. ones created by non-CloudFormation version of eksctl. It's debatable whether this flag may need to be on by default for backwards-compatibility, or we could just print a warning or something...The text was updated successfully, but these errors were encountered: