Make CloudFormation easier to compose #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 22, 2018
errordeveloper
force-pushed
the
goformation
branch
25 times, most recently
from
c45275e
to
6f54eaa
Compare
errordeveloper
force-pushed
the
goformation
branch
3 times, most recently
from
f560e8f
to
1552ba8
Compare
- simplify code - refactor task runner - define high-level task for CLI - add tag helper - define nodegroup-id tag - add WaitDeleteStack, WaitDeleteNodeGroup - use customised waiter based on AWS SDK
errordeveloper
force-pushed
the
goformation
branch
4 times, most recently
from
ef3e109
to
1a01c14
Compare
errordeveloper
force-pushed
the
goformation
branch
from
1a01c14
to
8baf89e
Compare
errordeveloper
changed the title
Closed
Closed
torredil
pushed a commit
to torredil/eksctl
that referenced
this pull request
May 20, 2022
Resolve memory addresses in log messages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a big change. We remove checked-in CloudFormation templates, in favour of Go code. It fixes #127.
The use-facing changes are:
--ssh-accessflag, which if turned off by default, as it turned out we didn't fully enable SSH access and SG changes were required to open port 22 (this was added mostly because it shows nicely how new model allows us modify templates easily without having to have to instances of LC wrapped with a conditional.--max-pods-per-nodeflag, which is also a good example of what was hard to expose beforeBug fixes:
--nodes=0will no longer hang waiting for actual nodesTODOs:
kubectl execandkubectl logsreview any improvements from Updated EKS AMI with bootstrap script awslabs/amazon-eks-ami#16(will be incorporated in follow-up PR)