Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

review parameter validation #28

Closed
errordeveloper opened this issue Jun 5, 2018 · 3 comments
Closed

review parameter validation #28

errordeveloper opened this issue Jun 5, 2018 · 3 comments
Labels
kind/feature New feature or request
Milestone
0.1.x – improvements

Comments

@errordeveloper
Copy link
Contributor

errordeveloper commented Jun 5, 2018 •
edited

Right now it's a bit ad-hoc, especially ASG size, but also instance types and regions are not validated at all.

https://github.com/weaveworks/eksctl/blob/0a39d1a2c1d107e1da90c27889d43bddba42ab3a/cmd/eksctl/create.go#L70
@errordeveloper errordeveloper added kind/feature New feature or request p2 labels Jun 5, 2018
This was referenced Jun 6, 2018
Merged
Closed
@errordeveloper errordeveloper added this to the 0.1.x – improvements milestone Jul 23, 2018
errordeveloper added a commit that referenced this issue Aug 9, 2018
@errordeveloper
Reference issue in all outstanding TODOs (#28, #156, #157, #158)
a7132d1
errordeveloper added a commit that referenced this issue Aug 10, 2018
@errordeveloper
Reference issue in all outstanding TODOs (#28, #156, #157, #158)
e9faa20
errordeveloper added a commit that referenced this issue Aug 10, 2018
@errordeveloper
Reference issue in all outstanding TODOs (#28, #156, #157, #158)
afcdc94
@richardcase richardcase removed the p2 label Aug 16, 2018
errordeveloper added a commit that referenced this issue Sep 4, 2018
@errordeveloper
Reference issue in all outstanding TODOs (#28, #156, #157, #158)
1a2ed11
errordeveloper added a commit that referenced this issue Sep 4, 2018
@errordeveloper
Reference issue in all outstanding TODOs (#28, #156, #157, #158)
16f80fd
errordeveloper added a commit that referenced this issue Sep 4, 2018
@errordeveloper
Reference issue in all outstanding TODOs (#28, #156, #157, #158)
8baf89e
@errordeveloper
Copy link
Contributor Author

I had a good go at this in #48, but that PR is dead in it's current form, yet I'd encourage those wanting to work on this to take a look at use of tagged config structs.

@errordeveloper
Copy link
Contributor Author

We still need to do this, but it needs to work for flags as well as the API. Namely, when using the API error messages need to be meaningful. We need to look into what Kubernetes does normally, and see what we can adapt from there, or at least do something that will work well in the context of Cluster API controller.

@errordeveloper
Copy link
Contributor Author

Closing in favour of #488.

torredil pushed a commit to torredil/eksctl that referenced this issue May 20, 2022
@bertinatto
Merge pull request eksctl-io#28 from leakingtapan/hack-scripts
6e933b4 
Add scripts for running go vet and go fmt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature New feature or request
Projects
None yet
Milestone
0.1.x – improvements
Development

Successfully merging a pull request may close this issue.

WIP: Add config parameter validation eksctl-io/eksctl
2 participants
@richardcase @errordeveloper